StarlingX

Tox configuration for distributedcloud not setup correctly

Bug #2033294 reported by Hugo Nicodemos Brito
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Hugo Nicodemos Brito

Bug Description

Brief Description
-----------------
The pylint configuration run by tox/zuul ignores code violations like 'line too long'.

Severity
--------
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
run tox command

Expected Behavior
------------------
The tox command output gets errors like 'line too long'.

Actual Behavior
----------------
tox pep8/pylint pass

Reproducibility
---------------
<Reproducible>

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
NA

Timestamp/Logs
--------------
NA

Test Activity
-------------
NA

Workaround
----------
NA

Hugo Nicodemos Brito (hbrito)
Changed in starlingx:
assignee: nobody → Hugo Nicodemos Brito (hbrito)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/892997

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/892998

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/892999

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/893000

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/892970
Committed: https://opendev.org/starlingx/distcloud/commit/80e07ef73398cd0e26f1bb8eecc975f7014150c7
Submitter: "Zuul (22348)"
Branch: master

commit 80e07ef73398cd0e26f1bb8eecc975f7014150c7
Author: Hugo Brito <email address hidden>
Date: Fri Aug 25 13:24:49 2023 -0300

    Update tox configuration for Distributed Cloud

    Cleanup the tox configuration and requirements.

    Test Plan:
    Verify that all Tox tests pass without errors.
    1. Successfully executed on the distributedcloud dir
    - tox -e docs,releasenotes,api-ref,bandit,linters
    - tox -e newnote -- new-note
    2. Successfully executed on the distributedcloud/distributedcloud dir
    - tox -e py39,pylint,pep8

    Partial-Bug: 2033294

    Change-Id: Ie7b2acb03c379708e8ef57b52d3c83560414f007
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/892997
Committed: https://opendev.org/starlingx/distcloud/commit/3685223b28194754fef89229724d795c6862014f
Submitter: "Zuul (22348)"
Branch: master

commit 3685223b28194754fef89229724d795c6862014f
Author: Hugo Brito <email address hidden>
Date: Mon Aug 28 16:57:52 2023 -0300

    Update tox pylint/pep8 for dcorch

    This commit enables the check of new pylint/pep8
    violations.

    PYLINT - All convention related checks, except:
    - missing-class-docstring
    - missing-function-docstring
    - missing-module-docstring
    - consider-using-f-string
    - invalid-name
    - import-outside-toplevel
    - too-many-lines
    - consider-iterating-dictionary
    - unnecessary-lambda-assignment

    PEP8:
    - E117: over-indented
    - E123: closing bracket does not match indentation
      of opening bracket's line
    - E125: continuation line with the same indent as the next
      logical line
    - E305: expected 2 blank lines after class or function
      definition
    - E402: module level import not at top of file
    - E501: line too long
    - H216: flag use of third party mock

    Test Plan:
    1. Verify that all Tox tests pass without errors:
    - tox -e py39,pylint,pep8

    Partial-bug: 2033294

    Change-Id: I834d15ae1df6b2b449502dcb0bcf0c359a99514f
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/892998
Committed: https://opendev.org/starlingx/distcloud/commit/a2b9bb7ab28a0da08dd4ba20dc97671eb10b6b50
Submitter: "Zuul (22348)"
Branch: master

commit a2b9bb7ab28a0da08dd4ba20dc97671eb10b6b50
Author: Hugo Brito <email address hidden>
Date: Mon Aug 28 17:13:55 2023 -0300

    Update tox pylint/pep8 for dccommon

    This commit enables the check of new pylint/pep8
    violations.

    PYLINT - All convention related checks, except:
    - missing-class-docstring
    - missing-function-docstring
    - missing-module-docstring
    - consider-using-f-string
    - invalid-name
    - import-outside-toplevel
    - too-many-lines
    - consider-iterating-dictionary
    - unnecessary-lambda-assignment

    PEP8:
    - E117: over-indented
    - E123: closing bracket does not match indentation
      of opening bracket's line
    - E125: continuation line with the same indent as the next
      logical line
    - E305: expected 2 blank lines after class or function
      definition
    - E402: module level import not at top of file
    - E501: line too long
    - H216: flag use of third party mock

    Test Plan:
    1. Perform `tox` command
    - Pass in py39, pylint, pep8

    Partial-bug: 2033294

    Change-Id: I45855e6bc23b61420281afc0132dd0662e292fc1
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/892999
Committed: https://opendev.org/starlingx/distcloud/commit/766f0522956d9e3a5272cff4dec06008d791c129
Submitter: "Zuul (22348)"
Branch: master

commit 766f0522956d9e3a5272cff4dec06008d791c129
Author: Hugo Brito <email address hidden>
Date: Mon Aug 28 17:29:13 2023 -0300

    Update tox pylint/pep8 for dcdbsync

    This commit enables the check of new pylint/pep8
    violations.

    PYLINT - All convention related checks, except:
    - missing-class-docstring
    - missing-function-docstring
    - missing-module-docstring
    - consider-using-f-string
    - invalid-name
    - import-outside-toplevel
    - too-many-lines
    - consider-iterating-dictionary
    - unnecessary-lambda-assignment

    PEP8:
    - E117: over-indented
    - E123: closing bracket does not match indentation
      of opening bracket's line
    - E125: continuation line with the same indent as the next
      logical line
    - E305: expected 2 blank lines after class or function
      definition
    - E402: module level import not at top of file
    - E501: line too long
    - H216: flag use of third party mock

    Test Plan:
    1. Perform `tox` command
    - Pass in py39, pylint, pep8

    Partial-bug: 2033294

    Change-Id: Ib3b3d36b8c4f48aa6a62744e01c1de9e11c65ad9
    Signed-off-by: Hugo Brito <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/893000
Committed: https://opendev.org/starlingx/distcloud/commit/4438b8fd5579f20ece09e670b712e3afd691bd79
Submitter: "Zuul (22348)"
Branch: master

commit 4438b8fd5579f20ece09e670b712e3afd691bd79
Author: Hugo Brito <email address hidden>
Date: Mon Aug 28 19:35:23 2023 -0300

    Update tox pylint/pep8 for dcmanager

    This commit enables the check of new pylint/pep8
    violations.

    PYLINT - All convention related checks, except:
    - missing-class-docstring
    - missing-function-docstring
    - missing-module-docstring
    - consider-using-f-string
    - invalid-name
    - import-outside-toplevel
    - too-many-lines
    - consider-iterating-dictionary
    - unnecessary-lambda-assignment

    PEP8:
    - E117: over-indented
    - E123: closing bracket does not match indentation
      of opening bracket's line
    - E125: continuation line with the same indent as the next
      logical line
    - E305: expected 2 blank lines after class or function
      definition
    - E402: module level import not at top of file
    - E501: line too long
    - H216: flag use of third party mock

    Test Plan:
    1. Perform `tox` command
    - Pass in py39, pylint, pep8

    Closes-bug: 2033294

    Change-Id: I635df8e809905cff582bd9d5eb57b91133560cf9
    Signed-off-by: Hugo Brito <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
summary: - Tox configuration for distributedcloud not correctly
+ Tox configuration for distributedcloud not setup correctly
tags: added: stx.9.0 stx.distcloud stx.zuul
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/906112

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/906112
Committed: https://opendev.org/starlingx/distcloud/commit/91c9d301d8cc9e16520599dd1f12d1a60b6370bb
Submitter: "Zuul (22348)"
Branch: master

commit 91c9d301d8cc9e16520599dd1f12d1a60b6370bb
Author: rlima <email address hidden>
Date: Fri Jan 19 10:42:23 2024 -0300

    Fix issues introduced by pylint/pep8 for dcmanager

    This commit fixes some regressions caused by the merge with
    master in the original commit.
    1 - Small formatting changes to be more consistent with
        existing code;
    2 - Removal of require_audit_flag that was mistakenly
        reintroduced during a rebase;
    3 - Repositioning of eventlet.monkey_patch() so it
        happens before the other imports;
    4 - Fix the admin IP conditional so it matches previous
        behavior;
    5 - Change the determine_image_fields conditional so it
        matches previous behavior.

    Related commit:
     https://review.opendev.org/c/starlingx/distcloud/+/893000

    Test Plan:
    1. Perform `tox` command
    - Pass in py39, pylint, pep8:

    Closes-bug: 2033294

    Change-Id: Icea2a80e2e4eed79f37bf49878e6fdea0db13a56
    Signed-off-by: rlima <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to distcloud (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/906311

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to distcloud (master)

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/906311
Committed: https://opendev.org/starlingx/distcloud/commit/da7b5b99bb429b809754d93c037f3927788abab0
Submitter: "Zuul (22348)"
Branch: master

commit da7b5b99bb429b809754d93c037f3927788abab0
Author: Hugo Brito <email address hidden>
Date: Mon Jan 22 15:07:43 2024 -0300

    Fix tox constraints and bandit

    This changes the upper-constraints to point to our internal,
    since the OpenStack Stein file doesn't exist anymore. Also,
    a small fix detected by the Bandit tool.

    Test Plan:
    - Execute: tox -e bandit

    Closes-bug: 2033294

    Change-Id: I8735bcd2ad23f4269d83a3ffc880a8588e72b5a3
    Signed-off-by: Hugo Brito <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.