System allows worker node to have admin interface created

[Mohammad Issa]

Brief Description

When installing a DX+ system, it is possible to create an interface and assign it to a network of type admin.

With that, the worker node fails to unlock.

-----------------

Severity

<Minor: System/Feature is usable with minor issue>

-----------------

Steps to Reproduce

Install DX+ subcloud using admin network.

Create a platform interface on the worker node and assign it to the admin type network.

-----------------

Expected Behavior

Assigning an interface on the worker node to the admin type network should not be allowed.

-----------------

Actual Behavior

Assigning an interface on the worker node to the admin type network is allowed.

-----------------

Reproducibility

Reproducible

-----------------

System Configuration

DX+ subcloud

-----------------

Last Pass

First time testing

-----------------

Workaround

Delete the admin interface and re-try worker node unlock

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/892011

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/892011
Committed: https://opendev.org/starlingx/config/commit/32b5f7e277f6d79283e1065b1093f81f65d7000e
Submitter: "Zuul (22348)"
Branch: master

commit 32b5f7e277f6d79283e1065b1093f81f65d7000e
Author: Mohammad Issa <email address hidden>
Date: Fri Aug 18 14:53:08 2023 +0000

    Restrict admin type interface to controllers nodes

    Installing a DX+ system, it is possible to create an interface
    and assign it to a network of type admin for non-controller nodes.

    The admin interface associated to admin network should be supported
    only for controller nodes. Worker nodes should reject the assignment
    of a platform interface to a network of type admin.

    Test Plan:
    - Build successful
    - Successfully bring up DC+ system
    - Create interface with admin network type
    - Verify worker node rejected the assigned interface

    Closes-Bug: 2031024

    Change-Id: I80886baa5d2d3dd45c4e67fb1b84d519924c8be3
    Signed-off-by: Mohammad Issa <email address hidden>