Add enhancement to list default Address pools row actions as disabled.

Bug #2030350 reported by rafael moyano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
rafael moyano

Bug Description

Title
-----
Horizon - Add enhancement to list default Address pools row actions as disabled.

Brief Description
-----------------
Default address pools are read-only by design. Consequently, any attempt to delete or update them will fail.
Address pools row actions dropdown menu could be disabled in order to prevent the unwanted behaviour.

Severity
--------
Minor.

Steps to Reproduce
------------------
1) Install AIO-SX or any other system type.
2) Go to Admin -> System Configuration > Address pools tab.
3) Try to update or delete one default address pool: Management, pxeboot, oam, multicast-subnet,
cluster-host-subnet, cluster-pod-subnet, cluster-service-subnet.
4) Error message is displayed: "Address pool is read-only and cannot be modified or removed".

Expected Behavior
------------------
Default address pool row has the dropdown menu disabled.
Custom address pool row has the dropdown menu enabled.

Actual Behavior
----------------
Every address pool row has the dropdown menu enabled.

Reproducibility
---------------
Reproducible 100%.

System Configuration
--------------------
Any system.

Test Activity
-------------
System Test.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to gui (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/890931

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to upstream (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/upstream/+/891042

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to upstream (master)

Reviewed: https://review.opendev.org/c/starlingx/upstream/+/891042
Committed: https://opendev.org/starlingx/upstream/commit/837787b4047e3fc68cfe98ab3a075baa549c5dd7
Submitter: "Zuul (22348)"
Branch: master

commit 837787b4047e3fc68cfe98ab3a075baa549c5dd7
Author: Rafael Moyano <email address hidden>
Date: Thu Aug 10 12:33:11 2023 -0300

    Add enabled condition for read-only address pools

    This condition will disable the address pools row dropdown
    menu for address pools created before bootstrap which are
    read-only and leave them enabled for address pools created
    post bootstrap which are not read-only.

    Test Plan:
    PASS: Build python-django-horizon package with these changes
     and install it in a system. Verify the changes are applied
      correctly.
    PASS: Build iso with these changes and perform a fresh
    install. Verify the changes are applied correctly.

    Partial-bug: 2030350

    Change-Id: Ieb0397dda8b4c8bc249faf1fd99b8218432fdc51
    Signed-off-by: Rafael Moyano <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to gui (master)

Reviewed: https://review.opendev.org/c/starlingx/gui/+/890931
Committed: https://opendev.org/starlingx/gui/commit/26d37f6eb64b33881ffdeb8afddd5c263f9940ac
Submitter: "Zuul (22348)"
Branch: master

commit 26d37f6eb64b33881ffdeb8afddd5c263f9940ac
Author: Rafael Moyano <email address hidden>
Date: Wed Aug 9 14:46:51 2023 -0300

    List default Address pools row actions as disabled

    Default address pools are read-only by design, any attempt to delete
     or update them will fail. Default address pools row actions dropdown
     menu has been disabled in order to prevent the unwanted behaviour.

    Test Plan:
    PASS: Go to Admin > System Configuration > Address Pools. Create one
    custom Address pool, save changes and wait until the address pools
    list is updated properly.
    PASS: Go to Admin > System Configuration > Address Pools. Select and
    update custom Address pool, save changes and wait until the address
    pools list is updated properly.
    PASS: Go to Admin > System Configuration > Address Pools. Select and
    delete custom Address pool, wait until the address pools list is
    updated properly.
    PASS: Go to Admin > System Configuration > Address Pools. Try to
    update default Address pool, actions is not allowed.
    PASS: Go to Admin > System Configuration > Address Pools. Try to
    delete default Address pool using dropdown option, actions is not
    allowed.

    Closes-bug: 2030350

    Depends-On: https://review.opendev.org/c/starlingx/upstream/+/891042

    Change-Id: I6219e958cf56eef588e0de07911180c9f6bfc55a
    Signed-off-by: Rafael Moyano <email address hidden>

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.9.0 stx.gui
Changed in starlingx:
assignee: nobody → rafael moyano (rmoyano)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.