Error returned when configuring AIO-SX subcloud with documented minimum management IP address

[Caio Bruchert]

Load Info
STX-8.0

System Config
Distributed Cloud + AIO-SX

Description of failure
Trying to bootstrap AIO-SX subcloud with only the minimum number of 4 management IP addresses as stated in Network Addressing Requirements

However, this configuration resulted in an error "management address range must contain at least 5 addresses."

Issue intermittent (Frequency of occurrence) or 100% Reproducible?
100%

Steps to Reproduce OR Events leading up to failure

Prepare Central Region
Pre-install subcloud and assign an OAM IP address
Using a bootstrap-values.yaml with only 4 management IP addresses, bootstrap and add the subcloud via the central region
Impact of Failure
Minor. Adding 1 more IP address to the range allows the bootstrapping to succeed.

Was the issue reproduced internally
Yes, in a VBOX environment

Summary of triage
Support was able to reproduce the issue. The following are the management IP values and console output:

# management IP values in bootstap-values.yaml.
management_subnet: 192.168.101.0/24
management_start_address: 192.168.101.2
management_end_address: 192.168.101.5
management_gateway_address: 192.168.101.1
Error reproduced:

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud add --bootstrap-address 192.168.10.83 --bootstrap-values bootstrap-values.yaml
Enter the sysadmin password for the subcloud:
Re-enter sysadmin password to confirm:
ERROR (app) The server could not comply with the request since it is either malformed or otherwise incorrect. management address range must contain at least 5 addresses

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/890534

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/890534
Committed: https://opendev.org/starlingx/distcloud/commit/c22c654147cb272b3b838caf3b5798b18cb21d87
Submitter: "Zuul (22348)"
Branch: master

commit c22c654147cb272b3b838caf3b5798b18cb21d87
Author: Caio Bruchert <email address hidden>
Date: Fri Aug 4 12:00:59 2023 -0300

    Fix minimum management IP address validation

    When installing a subcloud with the minimum of 4 management IP
    addresses the validation fails stating that the minimum number
    should be 5 but 4 should be allowed.

    Test Plan:
        PASS: install SX subcloud with 4 management addresses
        PASS: install DX subcloud with 4 management addresses

    Closes-Bug: 2030084

    Change-Id: I85b8de5ec3bc01bd9ccb24fb3f8d3b59cf547d44
    Signed-off-by: Caio Bruchert <email address hidden>