centos download failure when cengn url has cengn mirror prefix applied

[Scott Little]

Brief Description
-----------------
URL http://mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata
was extended with the cengn mirror prefix prior to download resulting in bad URL ...
http://mirror.starlingx.cengn.ca:80/mirror/centos/mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata

Severity
--------
Mo=ajor: Can't download lower layer content on centos builds

Steps to Reproduce
------------------
In an empty environment ...
download_mirror.sh -l distro

Expected Behavior
------------------
all required software to support a build is downloaded

Actual Behavior
----------------
Download of lower layer content from CENGN fails

Reproducibility
---------------
100%

System Configuration
--------------------
NA

Branch/Pull Time/Commit
-----------------------
Aug 1 2023, branch r/stx-7.0

Last Pass
---------
N/A

Timestamp/Logs
--------------
16:50:44 \cp --archive --link '/localdisk/designer/jenkins/rc-7.0-distro/stx-tools/centos-mirror-tools/output/stx/CentOS/layer_repos/compiler/std' '/localdisk/designer/jenkins/rc-7.0-distro/stx-tools/centos-mirror-tools/output/stx/CentOS/layer_repos/compiler/std.new'
16:50:44 --2023-08-02 20:50:44-- http://mirror.starlingx.cengn.ca/mirror/centos/mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata/
16:50:44 Resolving mirror.starlingx.cengn.ca (mirror.starlingx.cengn.ca)... 192.103.54.86
16:50:44 Connecting to mirror.starlingx.cengn.ca (mirror.starlingx.cengn.ca)|192.103.54.86|:80... connected.
16:50:44 HTTP request sent, awaiting response... 302 Moved Temporarily
16:50:44 Location: https://mirror.starlingx.cengn.ca/mirror/centos/mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata/ [following]
16:50:44 --2023-08-02 20:50:44-- https://mirror.starlingx.cengn.ca/mirror/centos/mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata/
16:50:44 Connecting to mirror.starlingx.cengn.ca (mirror.starlingx.cengn.ca)|192.103.54.86|:443... connected.
16:50:45 HTTP request sent, awaiting response... 404 Not Found
16:50:45 2023-08-02 20:50:45 ERROR 404: Not Found.
16:50:45
16:50:45 Error: get_remote_dir http://mirror.starlingx.cengn.ca:80/mirror/centos/mirror.starlingx.cengn.ca/mirror/starlingx/rc/7.0/centos/compiler/latest_build/outputs/RPMS/std/repodata /localdisk/designer/jenkins/rc-7.0-distro/stx-tools/centos-mirror-tools/output/stx/CentOS/layer_repos/compiler/std.new/repodata.upstream

Test Activity
-------------
Build

Workaround
----------
use full build, not layered

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.7.0
Review: https://review.opendev.org/c/starlingx/tools/+/890427

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/890427
Committed: https://opendev.org/starlingx/tools/commit/9557b5ca946c1daeb8d62d1244ec850a0fc552e9
Submitter: "Zuul (22348)"
Branch: r/stx.7.0

commit 9557b5ca946c1daeb8d62d1244ec850a0fc552e9
Author: Scott Little <email address hidden>
Date: Thu Aug 3 10:40:06 2023 -0400

    Fix download of lower layer rpms

    A recent change to centralize the conversion of
    URL to CENGN mirror URL was converting some URL's
    incorrectly. It should not convert a URL that is
    already a CENGN url.

    Closes-bug: 2029499
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I0ff68c366646a912ed330c8bf1733db020ef517b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.6.0
Review: https://review.opendev.org/c/starlingx/tools/+/890451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/890451
Committed: https://opendev.org/starlingx/tools/commit/5e8992d86f8d0878be497be1716d09c2e7708468
Submitter: "Zuul (22348)"
Branch: r/stx.6.0

commit 5e8992d86f8d0878be497be1716d09c2e7708468
Author: Scott Little <email address hidden>
Date: Thu Aug 3 10:40:06 2023 -0400

    Fix download of lower layer rpms

    A recent change to centralize the conversion of
    URL to CENGN mirror URL was converting some URL's
    incorrectly. It should not convert a URL that is
    already a CENGN url.

    Closes-bug: 2029499
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I7c94d5542c26e83b8a08d8f72d007dff971322ee