Brief Description
-----------------
After collecting data from sysinv.log, it's noticeable that sysinv reports system changes after just reading the list of disks in a different order, sending a report as if the system had changed, which is not the case.
Severity
--------
Minor: System/Feature is usable with minor issue.
Steps to Reproduce
------------------
Collecting sysinv.log in debug mode.
Actual Behavior
---------------
Log shows that exists various aliases to same disk device and the function returns these aliases in different order causing the change of device id chose in each execution and consequently the send of the update message to conductor.
Reproducibility
---------------
100% Reproducible.
System Configuration
---------------
Any
Last Pass
---------
This is a new test scenario.
Timestamp/Logs
--------------
sysinv.log - Device Node: /dev/sda; Device Id: scsi-SATA_VBOX_HARDDISK_VB277935d5-91a63d10
sysinv 2023-07-26 11:28:54.487 525728 DEBUG sysinv.zmq_rpc.zmq_rpc [-] Finished RPC server method idisk_update_by_ihost with context <sysinv.openstack.common.context.RequestContext object at 0x7fdb7a08f280> args {'ihost_uuid': 'a7c99215-a057-4b89-9b7f-cf66e31bf2c7', 'idisk_dict_array': [{'device_node': '/dev/sda', 'device_num': 2048, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-1.0', 'device_id': 'scsi-SATA_VBOX_HARDDISK_VB277935d5-91a63d10', 'device_wwn': None, 'size_mib': 300000, 'available_mib': 0, 'serial_id': 'VB277935d5-91a63d10', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}, {'device_node': '/dev/sdb', 'device_num': 2064, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-2.0', 'device_id': 'ata-VBOX_HARDDISK_VBc4091b24-089741a9', 'device_wwn': None, 'size_mib': 10000, 'available_mib': 0, 'serial_id': 'VBc4091b24-089741a9', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}, {'device_node': '/dev/sdc', 'device_num': 2080, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-3.0', 'device_id': 'scsi-SATA_VBOX_HARDDISK_VB273a5cc1-5bd32efe', 'device_wwn': None, 'size_mib': 10000, 'available_mib': 9996, 'serial_id': 'VB273a5cc1-5bd32efe', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}]} method /usr/lib/python3/dist-packages/sysinv/zmq_rpc/zmq_rpc.py:40
sysinv.log - Device Node: /dev/sda; Device Id: scsi-1ATA_VBOX_HARDDISK_VB277935d5-91a63d10
sysinv 2023-07-26 11:29:56.983 525728 DEBUG sysinv.zmq_rpc.zmq_rpc [-] Finished RPC server method idisk_update_by_ihost with context <sysinv.openstack.common.context.RequestContext object at 0x7fdb79d6d430> args {'ihost_uuid': 'a7c99215-a057-4b89-9b7f-cf66e31bf2c7', 'idisk_dict_array': [{'device_node': '/dev/sda', 'device_num': 2048, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-1.0', 'device_id': 'scsi-1ATA_VBOX_HARDDISK_VB277935d5-91a63d10', 'device_wwn': None, 'size_mib': 300000, 'available_mib': 0, 'serial_id': 'VB277935d5-91a63d10', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}, {'device_node': '/dev/sdb', 'device_num': 2064, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-2.0', 'device_id': 'scsi-0ATA_VBOX_HARDDISK_VBc4091b24-089741a9', 'device_wwn': None, 'size_mib': 10000, 'available_mib': 0, 'serial_id': 'VBc4091b24-089741a9', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}, {'device_node': '/dev/sdc', 'device_num': 2080, 'device_type': 'HDD', 'device_path': '/dev/disk/by-path/pci-0000:00:0d.0-ata-3.0', 'device_id': 'scsi-1ATA_VBOX_HARDDISK_VB273a5cc1-5bd32efe', 'device_wwn': None, 'size_mib': 10000, 'available_mib': 9996, 'serial_id': 'VB273a5cc1-5bd32efe', 'capabilities': {'model_num': 'VBOX HARDDISK'}, 'rpm': 'Undetermined'}]} method /usr/lib/python3/dist-packages/sysinv/zmq_rpc/zmq_rpc.py:40
Code Review: https:/