debian build - downloader fails to follow redirects

[Scott Little]

Brief Description
-----------------
A redirect is used to aid in the transition from mirror.starlingx.cengn.ca to mirror.starlingx.windriver.com.

Curl does not support redirects, unless the -L/--location options are specified.

The 'downloader' used by the debian build fails to use -L.

Severity
--------
Provide the severity of the defect.
Critical

Steps to Reproduce
------------------
downloader -s -b -B std

Expected Behavior
------------------
Download success

Actual Behavior
----------------
Download failure

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
July 25, 2023

Last Pass
---------
July 23, 2023 (pre-CENGN cutover)

Timestamp/Logs
--------------
2023-07-25 13:59:11,147 - downloader - INFO: [ Run - "['curl', '-k', '-f', 'http://mirror.starlingx.cengn.ca:80/mirror/debian/snapshot.debian.org/archive/debian/20220703T151735Z/pool/main/o/open-ath9k-htc-firmware/firmware-ath9k-htc_1.4.0-106-gc583009%2Bdfsg1-1_all.deb', '-o', '/import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb.tmp']" ]
2023-07-25 13:59:11,352 - downloader - DEBUG: stderr: % Total % Received % Xferd Average Speed Time Time Time Current
2023-07-25 13:59:11,353 - downloader - DEBUG: stderr: Dload Upload Total Spent Left Speed
2023-07-25 13:59:11,353 - downloader - DEBUG: stderr: 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
2023-07-25 13:59:11,353 - downloader - DEBUG: stderr: 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
2023-07-25 13:59:11,353 - downloader - INFO: [ Run - "['mv', '/import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb.tmp', '/import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb']" ]
2023-07-25 13:59:11,362 - downloader - INFO: firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1 download ok
2023-07-25 13:59:11,546 - repo_manager - INFO: Delete package, package not found.
2023-07-25 13:59:11,546 - repo_manager - INFO: Delete package, package not found.
2023-07-25 13:59:11,546 - downloader - DEBUG: Tried to delete the old firmware-ath9k-htc, ret 0
2023-07-25 13:59:11,570 - repo_manager - DEBUG: upload_pkg: upload package /import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb into deb-local-binary
2023-07-25 13:59:11,570 - repo_manager - DEBUG: upload_pkg: upload package /import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb into deb-local-binary
2023-07-25 13:59:11,570 - repo_manager - ERROR: Error: Unable to find global header
2023-07-25 13:59:11,570 - repo_manager - ERROR: Error: Unable to find global header
2023-07-25 13:59:11,571 - repo_manager - ERROR: Binary package /import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb read error.
2023-07-25 13:59:11,571 - repo_manager - ERROR: Binary package /import/mirrors/starlingx/binaries/firmware-ath9k-htc_1.4.0-106-gc583009+dfsg1-1_all.deb read error.
2023-07-25 13:59:11,571 - downloader - ERROR: Binary package error.
2023-07-25 13:59:11,571 - downloader - ERROR: Exception on uploading /import/mirrors/starlingx/binaries/zlib1g-dev_1.2.11.dfsg-2+deb11u2_amd64.deb to deb-local-binary

Test Activity
-------------
Build

Workaround
----------
N/A

[Davlet Panech (dpanech)]

Partial-Bug: https://review.opendev.org/c/starlingx/root/+/889438

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.6.0
Review: https://review.opendev.org/c/starlingx/tools/+/890450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/890450
Committed: https://opendev.org/starlingx/tools/commit/2b2379dc4f2244999143c3f65ff693026ac9669e
Submitter: "Zuul (22348)"
Branch: r/stx.6.0

commit 2b2379dc4f2244999143c3f65ff693026ac9669e
Author: Scott Little <email address hidden>
Date: Wed Aug 2 12:36:18 2023 -0400

    downloader fails to follow redirects

    A redirect is used to aid in the transition from
    mirror.starlingx.cengn.ca to mirror.starlingx.windriver.com.

    Curl does not support redirects, unless the -L/--location options
    are specified.

    Partial-Bug: 2028678
    Signed-off-by: Scott Little <email address hidden>
    Change-Id: I44a25952a832a5461f3833fbc74f267c2d72838a