Missing the % manifest_dir in input for %s in kubeapp.py results in ERROR log on application apply

[Joshua Reed]

Brief Description

in file https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py at line 3836:
LOG.error("Applying %s failed. Skipping helm release "
                              "cleanup...")
its missing the % manifest_dir in input for %s

Severity

Minor

Steps to Reproduce

Apply any application and run a failure scenario for system application-apply and check sysinv logs

Update 6/15/23:

On  AIO-SX machine
run system application-upload /usr/local/share/applications/helm/security-profiles-operator-22.12-1.tgz
run system application-list to validate the security profile application is uploaded successfully
run system application-apply security-profiles-operator to deploy the application
now check in /var/log/sysinv.log for log as :
sysinv 2023-06-15 05:13:13.175 79256 ERROR sysinv.conductor.kube_app [-] Applying %s failed. Skipping helm release cleanup...

Expected Behavior

LOG.error("Applying %s failed. Skipping helm release "
                              "cleanup...", % (manifest_dir))

Log output-
sysinv 2023-01-31 06:30:29.519 77163 ERROR sysinv.conductor.kube_app [-] Applying <app-manifest> failed. Skipping helm release cleanup...

Actual Behavior

Log output-
sysinv 2023-01-31 06:30:29.519 77163 ERROR sysinv.conductor.kube_app [-] Applying %s failed. Skipping helm release cleanup...

Reproducibility

issue is 100% reproducible,

System Configuration

Load info (eg: 2022-03-10_20-00-07)

Last Pass

Timestamp/Logs

sysinv 2023-01-31 06:30:29.519 77163 ERROR sysinv.conductor.kube_app [-] Applying %s failed. Skipping helm release cleanup...

Alarms

Test Activity

Workaround

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/886203

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/886203
Committed: https://opendev.org/starlingx/config/commit/50aa301e6d27bd1c19c03f567adae9c5b8174f4f
Submitter: "Zuul (22348)"
Branch: master

commit 50aa301e6d27bd1c19c03f567adae9c5b8174f4f
Author: Joshua Reed <email address hidden>
Date: Thu Jun 15 11:54:46 2023 -0700

    Correct Log bug in sysinv conductor.

    In file kube_app.py, the class FlucCDHelper has a function
    called make_fluxcd_operation. Inside there is a LOG.error
    with an invalid python string formatter. The manifest_dir
    string is missing, and this change corrects this issue.

    Test Plan:
    PASS: build-pkg -a && build-image
    PASS: full AIO-SX install
    PASS: run system application-upload
              /usr/local/share/applications/helm/security-profiles-operator-22.12-1.tgz
          run system application-list to validate the security
              profile application is uploaded successfully
          run system application-apply security-profiles-operator to deploy
              the application
          Last: observe the corrected log output in /var/log/sysinv.log

    Closes-Bug: 2024020
    Change-Id: Icfffd04309721193b71654927751b783b9c6ace2
    Signed-off-by: Joshua Reed <email address hidden>