STX-Openstack | fails to apply - yaml.load() require positional argument Loader

[Gabriel Calixto de Paula]

Brief Description
-----------------
The latest STX-Openstack master build is faling to apply/reapply, throwing an error :
The YAML function load() requires a positional argument: 'Loader'.
This seems to be associated to applying helm overrides and trying to apply/reapply the app

Severity
--------
Major, can't apply STX-O
Steps to Reproduce
------------------
1. apply STX-Openstack after enabling any helm-override
Expected Behavior
------------------
STX-O should apply/reapply
Actual Behavior
----------------
It fails to apply/reapply
Reproducibility
---------------
Seen Once

System Configuration
--------------------
Two-Node system
Branch/Pull Time/Commit
-----------------------
STX master 2023-05-28 06:00:00
STX-Openstack master 2023-05-28 20:17:33
Last Pass
---------
Yes, may-22 Build ran ok

Timestamp/Logs
--------------
+--------------------------+-----------------------------+-------------------------------------------+------------------+--------------+-----------------------------------------+
| application | version | manifest name | manifest file | status | progress |
+--------------------------+-----------------------------+-------------------------------------------+------------------+--------------+-----------------------------------------+
| cert-manager | 1.0-66 | cert-manager-fluxcd-manifests | fluxcd-manifests | applied | completed |
| nginx-ingress-controller | 1.0-46 | nginx-ingress-controller-fluxcd-manifests | fluxcd-manifests | applied | completed |
| oidc-auth-apps | 1.0-38 | oidc-auth-apps-fluxcd-manifests | fluxcd-manifests | uploaded | completed |
| platform-integ-apps | 1.0-114 | platform-integ-apps-fluxcd-manifests | fluxcd-manifests | applied | completed |
| stx-openstack | 1.0-1.stx.48-debian-stable- | stx-openstack-fluxcd-manifests | fluxcd-manifests | apply-failed | : load() missing 1 required positional |
| | versioned | | | | argument: 'Loader' |
| | | | | | |
+--------------------------+-----------------------------+-------------------------------------------+------------------+--------------+-----------------------------------------+

Test Activity
-------------
Sanity

Workaround
----------
N/A

[Thales Elero Cervi (tcervi)]

Thanks Gabriel,

this error is actually on the platform side, sysinv is throwing this exception when it tries to handle user helm-overrides. The exception started to happen after: https://review.opendev.org/c/starlingx/tools/+/881280

I will be submitting a fix proposal later today.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/884770

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/884770
Committed: https://opendev.org/starlingx/config/commit/a8d4e2971b25b88ff3db785ea5d56744a00cf4f6
Submitter: "Zuul (22348)"
Branch: master

commit a8d4e2971b25b88ff3db785ea5d56744a00cf4f6
Author: Thales Elero Cervi <email address hidden>
Date: Tue May 30 15:50:38 2023 -0300

    Fix yaml.load() calls on sysinv code

    After upversioning python3-yaml package [1] the yaml.load() method
    signature started requiring Loader as a mandatory argument [2].

    This change updates sysinv code entries where yaml.load() was called
    without specifying a loader, such that now it is compatible with the
    newest signature of yaml load calls.

    [1] https://review.opendev.org/c/starlingx/tools/+/881280
    [2] https://pyyaml.org/wiki/PyYAMLDocumentation

    TEST PLAN:
    PASS - Build sysinv package
    PASS - Build a new STX ISO
    PASS - Deploy the new ISO (virtual AIO-SX)

    Closes-Bug: 2021672

    Signed-off-by: Thales Elero Cervi <email address hidden>
    Change-Id: I36565dbb9ca65234e596578e2f2e4adeb3e1628a