Subcloud bootstrap failure is not showing appropriate BMC error message.

[rafael moyano]

Title
-----
Subcloud bootstrap failure is not showing appropriate BMC error message.

Brief Description
-----------------
Subcloud bootstrapping failed due to BMC connectivity. As a result, Ansible and dcmanager subcloud errors are showing a generic error message.

Severity
--------
Minor

Steps to Reproduce
------------------
1) Install central cloud.
2) Turn-off subcloud.
3) Kick-off subcloud bootstrapping from central cloud.

Expected Behavior
------------------
The following error message should be displayed:
"Failed to install the host via Redfish Virtual Media Controller.
Ping to BMC has failed. Check BMC values in install values file. Ensure you can ssh into BMC using these credentials. Err_code= ping_bmc"

Actual Behavior
----------------
Generic error message is displayed:
"Failed to install the host via Redfish Virtual Media Controller."

Reproducibility
---------------
Reproducible 100%

System Configuration
--------------------
Distributed Cloud

Test Activity
-------------
System Test

Timestamp/Logs
--------------
TASK [Fail if Redfish Virtual Media Controller job returns an error] *****
Monday 27 March 2023 06:30:44 +0000 (0:00:00.014) 0:04:43.926 *****
fatal: [subcloud1]: FAILED! => changed=false
  msg: |-
    Failed to install the host via Redfish Virtual Media Controller.

[sysadmin@controller-0 ~(keystone_admin)]$ dcmanager subcloud errors 10
FAILED installing playbook of (subcloud1).
 detail: fatal: [subcloud1]: FAILED! => changed=false
  msg: |-
    Failed to install the host via Redfish Virtual Media Controller.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/884772

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/884772
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/57fc5b35fc8b431af89d60bf28e9737aa6f383b0
Submitter: "Zuul (22348)"
Branch: master

commit 57fc5b35fc8b431af89d60bf28e9737aa6f383b0
Author: Rafael Moyano <email address hidden>
Date: Tue May 30 16:04:32 2023 -0300

    Subcloud bootstrap is not showing BMC error

    This commit fixes Ansible playbook in order to be caught by the 'when'
    condition. Consequently, BMC connectivity error message "Ping to BMC has
    failed. Check BMC values in install values file. Ensure you can ssh
    into BMC using these credentials. Err_code= ping_bmc" is displayed
    properly.

    Test Plan:
    PASS: Turn-off subcloud. Kick-off subcloud bootstrapping from central cloud,wait until bootstrap fails and BMC connectivity error message is displayed properly.

    Closes-bug: 2021552

    Change-Id: I8a3871988d36b5e2714ef163401d531f817d465e
    Signed-off-by: Rafael Moyano <email address hidden>