STX-Openstack Build: stx-nova fails to compile

[Lucas de Ataides Barreto]

Brief Description
-----------------
The image stx-nova fails to compile. It tries to clone a repo from github that seesm to have disappeared: https://github.com/freedesktop/spice-html5.git

Severity
--------
Critical: System/Feature is not usable due to the defect

Steps to Reproduce
------------------
Build packages, wheels and the base images
Build stx-nova

Expected Behavior
------------------
Build succeeds

Actual Behavior
----------------
Build fails

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
stx/master 2023-04-23 - https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/monolithic/20230423T060000Z/

Last Pass
---------
stx/master 2023-04-20 - https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/monolithic/20230420T060000Z/

Timestamp/Logs
--------------
https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/monolithic/20230423T060000Z/logs/by-build-number/build-docker-images-191.log.txt

[2023-04-23T18:12:07.357Z] + git clone -b spice-html5-0.1.6 --depth 1 https://github.com/freedesktop/spice-html5.git /usr/share/spice-html5
[2023-04-23T18:12:07.357Z] Cloning into '/usr/share/spice-html5'...
[2023-04-23T18:12:07.607Z] fatal: could not read Username for 'https://github.com': No such device or address
[2023-04-23T18:12:07.857Z] The command '/bin/sh -c /opt/loci/stx-scripts/install.sh' returned a non-zero code: 128

Test Activity
-------------
N/A

Workaround
----------
N/A

[Lucas de Ataides Barreto (ldeataid)]

A change is being made to the Openstack repos to change this repo: https://review.opendev.org/c/openstack/openstack-ansible/+/881336
The same must be done for starlingx/root

[Davlet Panech (dpanech)]

The offending line in starlingx/root is: https://opendev.org/starlingx/root/src/commit/c4d81443b8daf186d64288975a608c33bcf74006/build-tools/build-docker-images/build-stx-images.sh#L44

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/881484

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/881488

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lucas de Ataides Barreto <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/root/+/881484
Reason: Going to be tracked by https://review.opendev.org/c/starlingx/root/+/881488

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/881488
Committed: https://opendev.org/starlingx/root/commit/7af589cf440098fe1ed57aa646f7094305f72afb
Submitter: "Zuul (22348)"
Branch: master

commit 7af589cf440098fe1ed57aa646f7094305f72afb
Author: Davlet Panech <email address hidden>
Date: Tue Apr 25 15:49:05 2023 +0000

    docker-images: update default spice-html5 git URL

    The original URL has been removed from github:

      https://github.com/freedesktop/spice-html5.git

    Replace it with a mirror:

      https://gitlab.freedesktop.org/spice/spice-html5

    See also: https://review.opendev.org/c/openstack/openstack-ansible/+/881336

    TESTS
    ==================================

    Build stx-nova images

    Closes-Bug: 2017592
    Signed-off-by: Davlet Panech <email address hidden>
    Change-Id: I15fa71e9ca607e9b03f92ba4926562a67a528cef

[Ghada Khalil (gkhalil)]

@Lucas, Based on the community call, we believe the same change will be needed for the release branches: r/stx.6.0, r/stx.7.0, r/stx.8.0. Please inspect the source code for these branches and update if applicable.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.8.0
Review: https://review.opendev.org/c/starlingx/root/+/881440

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: r/stx.7.0
Review: https://review.opendev.org/c/starlingx/root/+/881441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/881441
Committed: https://opendev.org/starlingx/root/commit/2b492d7b9ed688ebec751d840371e7697d35541c
Submitter: "Zuul (22348)"
Branch: r/stx.7.0

commit 2b492d7b9ed688ebec751d840371e7697d35541c
Author: Davlet Panech <email address hidden>
Date: Tue Apr 25 15:49:05 2023 +0000

    docker-images: update default spice-html5 git URL

    The original URL has been removed from github:

      https://github.com/freedesktop/spice-html5.git

    Replace it with a mirror:

      https://gitlab.freedesktop.org/spice/spice-html5

    See also: https://review.opendev.org/c/openstack/openstack-ansible/+/881336

    TESTS
    ==================================

    Build stx-nova images

    Closes-Bug: 2017592
    Signed-off-by: Davlet Panech <email address hidden>
    Change-Id: I15fa71e9ca607e9b03f92ba4926562a67a528cef
    (cherry picked from commit 7af589cf440098fe1ed57aa646f7094305f72afb)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/881440
Committed: https://opendev.org/starlingx/root/commit/af136024e7c249f47644e70c235a87b1de19af16
Submitter: "Zuul (22348)"
Branch: r/stx.8.0

commit af136024e7c249f47644e70c235a87b1de19af16
Author: Davlet Panech <email address hidden>
Date: Tue Apr 25 15:49:05 2023 +0000

    docker-images: update default spice-html5 git URL

    The original URL has been removed from github:

      https://github.com/freedesktop/spice-html5.git

    Replace it with a mirror:

      https://gitlab.freedesktop.org/spice/spice-html5

    See also: https://review.opendev.org/c/openstack/openstack-ansible/+/881336

    TESTS
    ==================================

    Build stx-nova images

    Closes-Bug: 2017592
    Signed-off-by: Davlet Panech <email address hidden>
    Change-Id: I15fa71e9ca607e9b03f92ba4926562a67a528cef
    (cherry picked from commit 7af589cf440098fe1ed57aa646f7094305f72afb)