Subcloud upgrade: During migrating data step subcloud list showing online but unable to ping from central cloud

[Christopher de Oliveira Souza]

Brief Description
--------------------
During the subcloud upgrade when migrating data dcmanager subcloud list showing subcloud is online. subcloud1 ping was failing

Severity
--------------------
Minor:

Steps to Reproduce
--------------------
1. Install upgrade
2. Follow upgrade procedure and upgrade the Central cloud
3. Uprade subcloud when subcloud is in migrating data state verify dcmanager subcloud list and ping subcloud

Expected Behavior
--------------------
dcmanager subcloud list shouldn't show online when ping to sub cloud was failing.

Actual Behavior
--------------------
[sysadmin@controller-1 ~(keystone_admin)]$ dcmanager strategy-step list
+-----------+-------+----------------+---------+----------------------------+-------------+
| cloud | stage | state | details | started_at | finished_at |
+-----------+-------+----------------+---------+----------------------------+-------------+
| subcloud1 | 1 | migrating data | | 2023-03-13 19:09:38.525398 | None |
+-----------+-------+----------------+---------+----------------------------+-------------+
[sysadmin@controller-1 ~(keystone_admin)]$ dcmanager subcloud list
+----+-----------+------------+--------------+----------------+-------------+---------------+-----------------+
| id | name | management | availability | deploy status | sync | backup status | backup datetime |
+----+-----------+------------+--------------+----------------+-------------+---------------+-----------------+
| 1 | subcloud1 | managed | online | migrating-data | out-of-sync | None | None |
+----+-----------+------------+--------------+----------------+-------------+---------------+-----------------+
[sysadmin@controller-1 ~(keystone_admin)]$ ping6 subcloud1
PING subcloud1(subcloud1 (fd00:8:33::2)) 56 data bytes

--- subcloud1 ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 1033ms

[sysadmin@controller-1 ~(keystone_admin)]$ ping subcloud1
PING subcloud1(subcloud1 (fd00:8:33::2)) 56 data bytes

--- subcloud1 ping statistics ---
6 packets transmitted, 0 received, 100% packet loss, time 5097ms

Reproducibility
------------------
This issue is 100% reproducible

System Configuration
------------------
21.12 Patch 8 + upgrade Patch 0006

Last Pass
------------------
Not known

Timestamp/Logs
------------------
N/A

Alarms
------------------
N/A

Test Activity
------------------
Regression

Workaround
------------------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/880869

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/880869
Committed: https://opendev.org/starlingx/distcloud/commit/d76f79b9bcbcbe2f0ec76dc3f1d75809f0692efd
Submitter: "Zuul (22348)"
Branch: master

commit d76f79b9bcbcbe2f0ec76dc3f1d75809f0692efd
Author: Christopher Souza <email address hidden>
Date: Wed Apr 19 13:31:04 2023 -0300

    Set subcloud to offline before reinstalling

    In this commit, the DC upgrade orchestrator was updated to make
    sure the subcloud would be offline during installation and migrating
    data stages. This was changed to avoid misleading output when
    checking the subcloud availability. Before this change, during the
    mentioned stages, the availability would be online, even though it
    was not possible to ping the subcloud. When the subcloud deploy
    status changes to migrated, install failed or migration failed,
    the audit will be triggered and the availability will be set
    accordingly.

    Test Plan:
    PASS: upgrade system controller and sx subcloud and when orchestration
    reach upgrade simplex, verify that subcloud is offline. Once subcloud
    deploy status changes to migrated, verify that the subcloud is online.

    Closes-Bug: 2017012

    Signed-off-by: Christopher Souza <email address hidden>
    Change-Id: Ie13e5750fabd35cc91689d5b7f9d3e09f637bba7