Networking: maintenance heartbeats are not classified as high priority traffic

[Lucas Ratusznei Fonseca]

Brief Description
-----------------
Maintenance heartbeats are no longer being treated as high priority traffic.
This change occurred according to the following bug/commit:
https://bugs.launchpad.net/starlingx/+bug/1839386
https://opendev.org/starlingx/utilities/commit/fc33582e4fdaa4d2725f2d7c23395a3e4c19daba
We need to add filters for the following UDP ports to the tc_setup.sh script:
hbs_client_mgmnt_port = 2106; Management Interface Heartbeat Pulse Request Rx Port
hbs_agent_mgmnt_port = 2103; Management Interface Heartbeat Pulse Response Rx Port
A symptom of this may be large amounts of heartbeat loss messages in mtcAgent.log under high traffic load.

Severity
--------
Minor.

Expected Behavior
------------------
This traffic should be treated as high priority. That is, it should be getting directed to the 10: hi prio qdisc of the 1:10 class.

Actual Behavior
----------------
Heartbeat traffic for ports 2103 and 2106 are not treated as high priority.

Reproducibility
---------------
100% reproducible.

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Master

Last Pass
---------
18.03

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
Create filters manually with tc command.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/880265
Committed: https://opendev.org/starlingx/utilities/commit/f363a5ded6c4632e6effcae9e2028e5911405b02
Submitter: "Zuul (22348)"
Branch: master

commit f363a5ded6c4632e6effcae9e2028e5911405b02
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Thu Apr 13 02:43:09 2023 -0300

    Add filters for management network heartbeat ports

    Add filters to treat Service Management and Maintenance management
    network heartbeat traffic ports as high priority.

    Test plan

    Procedure:
    1. Apply changes to the script
    2. Lock/unlock host
    3. Use command 'tc -s filter show dev enp0s8' to check heartbeat
       statistics incrementing

    PASS Test the filters' effectiveness on an IPv4 AIO-DX.
    PASS Test the filters' effectiveness on an IPv6 AIO-DX.

    Closes-Bug: #2016055
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>
    Change-Id: I76bf553bb30d56e37b8a263795eaa79eede02d31

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/utilities/+/881577

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/881577
Committed: https://opendev.org/starlingx/utilities/commit/eb621997805614c61bf717d45c4e22276d657b45
Submitter: "Zuul (22348)"
Branch: master

commit eb621997805614c61bf717d45c4e22276d657b45
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Wed Apr 26 11:38:00 2023 -0300

    Fix calls to heartbeat traffic control setup function

    In the previous commit, the calls to the function
    setup_tc_heartbeat_port_filter are misspelled, this commit fixes the
    issue.

    Reference: https://opendev.org/starlingx/utilities/commit/f363a5ded6c4632e6effcae9e2028e5911405b02

    Test plan

    Procedure:
    1. Apply changes to the script
    2. Lock/unlock host
    3. Use command 'tc -s filter show dev enp0s8' to check heartbeat
       statistics incrementing

    PASS Test the filters' effectiveness on an IPv4 AIO-DX.
    PASS Test the filters' effectiveness on an IPv6 AIO-DX.

    Closes-Bug: #2016055
    Change-Id: I06a9ea4ae1e1415106cfdd8d935cc19f407e9ea2
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>