Restore complete is not sent at end of dcmanager subcloud restore playbook

[Gustavo Lyra Pereira]

Brief Description
-----------------
Command restore-complete must be sent at the end of restore process

Severity
--------
Major

Steps to Reproduce
------------------
Create a subcloud backup and run the restore.

Expected Behavior
------------------
Subcloud deploy status must be as completed.

Actual Behavior
----------------
Subcloud deploy status stuck in "restoring".

Reproducibility
---------------
Reproducible

System Configuration
--------------------
dc with 2 subclouds.

Branch/Pull Time/Commit
-----------------------
Master 22.12 2023-02-28 23:00:09 +0000

Last Pass
---------
NA

Timestamp/Logs
--------------
/var/log/sysinv.log continually emits these messages.

sysinv 2023-03-02 16:25:35.077 100840 INFO sysinv.conductor.manager [-] Restore in progress - defer platform managed application activity

Test Activity
-------------
NA

Workaround
----------
Run the command system restore-complete manually in the subcloud.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/878564

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/878564
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/b78cb79d435acf18bef8950b756278af67f52929
Submitter: "Zuul (22348)"
Branch: master

commit b78cb79d435acf18bef8950b756278af67f52929
Author: Gustavo Pereira <email address hidden>
Date: Fri Mar 24 18:37:21 2023 -0300

    Finalize subcloud restore with system restore-complete

    Currently the subcloud restore is not finalized by
    running system restore-complete command.
    There's no apparent impact to the subcloud operations
    post restore. However, sysinv is emitting
    "Restore in progress - defer platform managed
    application activity" logs. This commit addresses
    the issue.

    Test Plan:
    PASS: Take a subcloud backup, unmanage the
    subcloud and perform subcloud restore using
    dcmanager subcloud-backup restore command.
    Verify there are no sysinv "Restore in progress"
    logs and the subcloud is fully operational post
    restore.
    The test environment to execute the restore was
    built with 2 controllers and 2 subclouds where
    subclouds are installed but not bootstrapped,
    and the network was manually configured.

    Closes-Bug: 2012775

    Signed-off-by: Gustavo Pereira <email address hidden>
    Change-Id: If80787a256400ff0f08dc0f4d852d12237e50d7e