PTP ptp-notification excessive amount of RPCClient warning messages

[Andre Mauricio Zelak]

Brief Description
-----------------

The ptp-notification-ptptracking application is showing an excessive amount of the RPCClient warnings, like:

2023-02-21 22:22:59 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.

Severity
--------

Minor

Steps to Reproduce
------------------
Upload and apply ptp-notification application.
kubectl get pods -n notification -o=wide
kubectl logs -f -n notification ptp-ptp-notification-dq42c -c ptp-notification-ptptracking

Expected Behavior
------------------

No more warnings like this.

Actual Behavior
----------------

A lot of warning messages like the following are shown:

2023-02-21 22:22:59 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.

Reproducibility
---------------

Always

System Configuration
--------------------

Applies to all type os systems with PTP configuration and ptp-notification application.

Branch/Pull Time/Commit
-----------------------

stx master 2022-12

Last Pass
---------

stx master 2022-11

Timestamp/Logs
--------------

kubectl logs -f -n notification ptp-ptp-notification-dq42c -c ptp-notification-ptptracking

2023-02-21 22:22:59 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:22:59 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:01 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:01 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:04 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:04 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:06 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:06 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:09 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:09 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:11 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:11 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:14 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:14 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:16 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:16 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:19 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:19 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:21 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:21 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:24 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:24 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:26 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:26 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.
2023-02-21 22:23:29 WARNING Using RPCClient manually to instantiate client. Please use get_rpc_client to obtain an RPC client instance.

Test Activity
-------------

Feature Testing

Workaround
----------

Use grep -v. For example:
kubectl logs -f -n notification ptp-ptp-notification-dq42c -c ptp-notification-ptptracking | grep -v "Using RPCClient manually"

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/877558
Committed: https://opendev.org/starlingx/ptp-notification-armada-app/commit/e17699d3d1b50955455d46d5c79b4a9078aa054b
Submitter: "Zuul (22348)"
Branch: master

commit e17699d3d1b50955455d46d5c79b4a9078aa054b
Author: Andre Mauricio Zelak <email address hidden>
Date: Wed Mar 15 15:02:16 2023 -0300

    Use new get_rpc_client API from oslo.messaging

    Use the new get_rpc_client API to handle the RCPClient
    instantiation.

    This new API was added into oslo.messaging here [1].

    [1] https://review.opendev.org/c/openstack/oslo.messaging/+/862419

    Closes-bug: 2011620

    Signed-off-by: Andre Mauricio Zelak <email address hidden>
    Change-Id: I2322d0bb49b342f8eec49f599257f9dac83b3d8a