Removing reading file process in a subprocess
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
Junfeng Li |
Bug Description
Brief Description
-------
"Too many open files" error was seen during controller 1 startup related to lldpcli execution in a subproess. It is likely caused by reading OS release file during subprocess being called.
Severity
---------
Minor
Steps to Reproduce
---------
Unknown
Expected Behavior
------------------
Controller startup succeeds
Actual Behavior
----------------
Controller startup failed
Reproducibility
---------------
No
System Configuration
-------
AIO-DX
Timestamp/Logs
--------------
sysinv 2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
2023-03-02 13:56:08.153 75460 ERROR sysinv.
Workaround
----------
Possible lock/unlock the controller again from active controller
Changed in starlingx: | |
status: | New → In Progress |
Changed in starlingx: | |
importance: | Undecided → Low |
tags: | added: stx.9.0 stx.config |
Changed in starlingx: | |
assignee: | nobody → Junfeng Li (jli14) |
Reviewed: https:/ /review. opendev. org/c/starlingx /config/ +/876986 /opendev. org/starlingx/ config/ commit/ 52323722885ec2d b7e4a5b3e56e47a f37a2fab6c
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 52323722885ec2d b7e4a5b3e56e47a f37a2fab6c
Author: Junfeng (Shawn) Li <email address hidden>
Date: Thu Mar 9 10:15:34 2023 -0500
Removing reading file process in a subprocess
Details: This commit is to enhance the execution of lldpcli
in the subprocess.
The existing way is reading the OS release file during subprocess
execution. This file reading requires an extra file descriptor.
The commit is to only take "json0" value for Debian OS as
moving forward only Debian OS is supported.
Test Plan:
PASS: upgrade from 21.12 to 22.12 with this commit
PASS: fresh installation with this commit
Closes-Bug: 2009962
Signed-off-by: Junfeng (Shawn) Li <email address hidden> ee14a8c20513c39 8efcfa1d6e7
Change-Id: I1b35ab07775bba