Script update CentOs partition to Debian failing with multipath

[Lucas Borges]

Brief Description
--------

When the script /etc/upgrade.d/10-update-centos-partition-to-debian.py performs return errors.

Severity
-------

Major: System/Feature is usable but degraded

Steps to Reproduce
-------
Perform upgrade with multipath

Actual Behavior
-------
The script returns an error:

Exception: Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with return code 1 Script output:

Reproducibility
-------

100% Reproducible

System Configuration:
-------
AIO-SX

Upgrade system with multipath

Timestamp/Logs
-------

2023-02-16T17:09:31.338 localhost configassistant[146381] info /etc/upgrade.d/10-update-centos-partition-to-debian.py:52     INFO [__main__] /etc/upgrade.d/10-update-centos-partition-to-debian.py invoked action = migrate
2023-02-16T17:09:31.875 localhost configassistant[146381] err /etc/upgrade.d/10-update-centos-partition-to-debian.py:600    ERROR [__main__] list index out of range
Traceback (most recent call last):
  File "/etc/upgrade.d/10-update-centos-partition-to-debian.py", line 572, in do_update
    controller_partitions = get_controller_partition_template(rootdisk)
  File "/etc/upgrade.d/10-update-centos-partition-to-debian.py", line 197, in get_controller_partition_template
    sorted_list[-1]["end_mib"] = END_OF_DISK_MIB
IndexError: list index out of range
2023-02-16T17:09:31.875 localhost configassistant[146381] warning /etc/upgrade.d/10-update-centos-partition-to-debian.py:601  WARNING [__main__] Rollback changes
2023-02-16T17:09:32.126 localhost upgrade_controller_simplex: err 2023-02-16 17:09:32.124 145013 ERROR controllerconfig.upgrades.utils [-] Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
2023-02-16T17:09:32.128 localhost upgrade_controller_simplex: err 2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils [-] Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
: Exception: Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils Traceback (most recent call last):
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils   File "/usr/lib/python3/dist-packages/controllerconfig/upgrades/utils.py", line 111, in execute_migration_scripts
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils     raise Exception(msg)
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils Exception: Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils
2023-02-16 17:09:32.126 145013 ERROR controllerconfig.upgrades.utils
2023-02-16T17:09:32.131 localhost upgrade_controller_simplex: err 2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller [-] Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
: Exception: Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller Traceback (most recent call last):
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller   File "/usr/lib/python3/dist-packages/controllerconfig/upgrades/controller.py", line 1516, in simplex_main
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller     upgrade_controller_simplex(backup_file)
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller   File "/usr/lib/python3/dist-packages/controllerconfig/upgrades/controller.py", line 1453, in upgrade_controller_simplex
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller     utils.execute_migration_scripts(
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller   File "/usr/lib/python3/dist-packages/controllerconfig/upgrades/utils.py", line 111, in execute_migration_scripts
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller     raise Exception(msg)
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller Exception: Migration script /etc/upgrade.d/10-update-centos-partition-to-debian.py failed with returncode 1Script output:
2023-02-16 17:09:32.130 145013 ERROR controllerconfig.upgrades.controller

Test Activity
-------
Test upgrade with multipath

Workaround
-------
No workaround

Steps to Reproduce
------------------
Write down the steps to reproduce the issue

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/874250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/874250
Committed: https://opendev.org/starlingx/config/commit/f2549ad0972c3745454c3e15371c8d2fde08f610
Submitter: "Zuul (22348)"
Branch: master

commit f2549ad0972c3745454c3e15371c8d2fde08f610
Author: Lucas Borges <email address hidden>
Date: Fri Feb 17 10:01:19 2023 -0300

    CentOs partition to debian failing with multipath

    In the script when updating the CentOs partition
    to Debian occurs a mismatch with multipath paths.
    This fix is specific to upgrade multipath systems

    Test Plan:

    PASS: Upgrade AIO-SX with multipath
    PASS: Upgrade AIO-DX with multipath
    PASS: Upgrade AIO-SX without multipath
    PASS: Upgrade AIO-DX without multipath

    Closes-bug: 2007690
    Change-Id: I833381a7dfdc89327e271d3772ee90012383cb95
    Signed-off-by: Lucas Borges <email address hidden>