STX-Openstack: qemu-img: command not found

[Lucas de Ataides Barreto]

Brief Description
-----------------
Issuing "qemu-img" will return a "command not found". Looks like the qemu-utils package is not being installed

Severity
--------
Minor: System/Feature is usable with minor issue

Steps to Reproduce
------------------
Issue any "qemu-img" commands

Expected Behavior
------------------
qemu-img commands work fine

Actual Behavior
----------------
qemu-img commands are returning "command not found"

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Bare metal two node system

Branch/Pull Time/Commit
-----------------------
https://mirror.starlingx.cengn.ca/mirror/starlingx/master/debian/monolithic/20230213T070000Z/

Last Pass
---------
Never ran this on Debian before

Timestamp/Logs
--------------
sysadmin@controller-1:~$ qemu-img
-bash: qemu-img: command not found
sysadmin@controller-1:~$ which qemu
sysadmin@controller-1:~$ which qemu-img
sysadmin@controller-1:~$

Test Activity
-------------
Feature Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/873733

[Thales Elero Cervi (tcervi)]

The qemu-utils package delivers this requested binary. Adding it to the ISO made this utility available on Debian:

$ sudo apt list --installed | grep qemu-utils
qemu-utils/bullseye,now 1:5.2+dfsg-11+deb11u2.stx.1 amd64 [installed]

$ sudo dpkg -L qemu-utils
/.
/usr
/usr/bin
/usr/bin/qemu-img
/usr/bin/qemu-io
/usr/bin/qemu-nbd
/usr/sbin
/usr/sbin/qemu-make-debian-root
/usr/share
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/qemu-img.1.gz
/usr/share/man/man1/qemu-io.1.gz
/usr/share/man/man8
/usr/share/man/man8/qemu-make-debian-root.8.gz
/usr/share/man/man8/qemu-nbd.8.gz

$ qemu-img -V
qemu-img version 5.2.0 (Debian 1:5.2+dfsg-11+deb11u2.stx.1)
Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/integ/+/873733
Committed: https://opendev.org/starlingx/integ/commit/2a0887fb97c660147ed7a1d1ca09e68419ebfc60
Submitter: "Zuul (22348)"
Branch: master

commit 2a0887fb97c660147ed7a1d1ca09e68419ebfc60
Author: Thales Elero Cervi <email address hidden>
Date: Tue Feb 14 14:01:14 2023 -0300

    Add qemu-utils package to platform ISO

    This change adds the qemu-utils package to StarlingX ISO.
    This might be one utility of interest for users of our stx-openstack
    application and was reported to be missing [1] when comparing to our
    previous CentOS version.

    After the Debian migration, QEMU was upversioned to be based on the
    latest officially supported version for Debian Bullseye. The packages
    are now split into new packages and qemu-utils is one of them.

    To have the qemu-img binary available, qemu-utils needs to be installed
    [2]. This binary allows one to create, convert and modify images
    offline and handles all image formats supported by QEMU [3].

    [1] bug/2007267
    [2] https://salsa.debian.org/qemu-team/qemu/-/blob/debian/qemu_5.2+dfsg-11+deb11u2/debian/qemu-utils.install#L1
    [3] https://www.qemu.org/docs/master/tools/qemu-img.html

    TEST PLAN:
    PASS - Ensure the qemu packages build generates qemu-utils*.deb
    PASS - Ensure ISO can be built with qemu-utils*.deb installed
    PASS - Bootstrap an AIO-SX system with the new ISO
    PASS - Check the installed package and delivered files
           * apt list --installed | grep qemu-utils
           * dpkg -L qemu-utils
    PASS - Ensure the "qemu-img" is found
           * qemu-img -V

    Closes-Bug: 2007267

    Signed-off-by: Thales Elero Cervi <email address hidden>
    Change-Id: Ifcaab24540cfe6a922d1d08c4b63dc8a322cf437