puppet fails due to hyper-thread being change in runtime

[Romão Martines]

Brief Description
-----------------
Using system host-cpu-modify when hyperthread is disabled causes a Mismatched CPUs error at Grub Audit and consequently fails puppet because of the lack of 'ensure' variable attrubuition.

Severity
--------
Minor

Steps to Reproduce
------------------
Disable Hyperthread. Lock the controller and run system host-cpu-modify changing the number of platform cores. Unlock and reboot the machine. You can see errors inside puppet logs regarding Mismatched CPUs and puppet's compute file.

Expected Behavior
------------------
Hyperthread can be disabled without causing any errors related to Mismatched CPUs.

Actual Behavior
----------------
Mismatched CPU error happens ate Grub Audit and consequently fails puppet at compute.pp

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master/ 2023-01-26.

Last Pass
---------
N/A

Timestamp/Logs
--------------
2023-01-31 18:22:55 +0000 Scope(Class[Platform::Compute::Grub::Audit]): Mismatched CPUs: Found=36, Expected=18.
2023-01-31 18:22:55 +0000 Evaluation Error: Unknown variable: 'ensure'.

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/872556
Committed: https://opendev.org/starlingx/stx-puppet/commit/09e3887518d2a4a01e5df680d6dbad42f7d67142
Submitter: "Zuul (22348)"
Branch: master

commit 09e3887518d2a4a01e5df680d6dbad42f7d67142
Author: Romão Martines <email address hidden>
Date: Tue Mar 7 13:32:46 2023 -0500

    Resolving "unknown variable ensure".

    When Hypertreading is disabled, system host-cpu-modify fails since
    ensure definition is not set. At reboot phase, on Grub Audit, due
    the lack of ensure definition, it will get a Mismatched CPUs error.

    Adding ensure definition made the Grub Audit phase pass with no
    errors and the host-cpu-modify work properly.

    TEST PLAN:
    PASS: Change the number of Platform Cores to 4.
    PASS: Change the number of Platform Cores to 1.
            (get succssesfully two core minimum message).
    PASS: Check puppet logs: No error on Grub Audit.
    PASS: Check puppet logs: No error about ensure.
    PASS: Extra reboot: Not happening.
    PASS: Disable nohz successfully.

    Bug: 2004593

    Signed-off-by: Romão Martines <email address hidden>
    Change-Id: I62d55d796621e3ec4f382bcfd44d308184aa2e5a