Unable to Create RBD Volume Snapshot

[Hediberto Cavalcante da Silva]

Brief Description
-----------------

After install snapshot-controller and snapshot CRDs, user is unable to create RBD volume snapshot.
Watching the volumesnapshot created, the READYTOUSE value is in 'FALSE' state and never coming to be in 'TRUE' state.

Severity
--------
Minor

Steps to Reproduce
------------------

1. Install snapshot CRDs >= v4.2.
2. Install snapshot-controller >= v4.2.
3. Create a pvc.
4. Create a volumesnapshotclass.
5. Create a volumesnapshot.

Get the volumesnapshot created and check if READYTOUSE is true.

Expected Behavior
------------------
The created snapshot is ready to use.

Actual Behavior
----------------
The created snapshot is not ready to use.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-SX

Timestamp/Logs
--------------

sysadmin@controller-0:~$ kubectl get volumesnapshot rbd-pvc-snapshot
NAME READYTOUSE SOURCEPVC SOURCESNAPSHOTCONTENT RESTORESIZE SNAPSHOTCLASS SNAPSHOTCONTENT CREATIONTIME AGE
rbd-pvc-snapshot false rbd-pvc 1Gi csi-rbdplugin-snapclass snapcontent-3f49f665-d9fa-4cd5-8e5b-e4388c211e66 67m 67m

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/platform-armada-app/+/871789

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/platform-armada-app/+/871789
Committed: https://opendev.org/starlingx/platform-armada-app/commit/cad2f45bec2e96776e596c1e9831136d3f16056c
Submitter: "Zuul (22348)"
Branch: master

commit cad2f45bec2e96776e596c1e9831136d3f16056c
Author: Hediberto Cavalcante da Silva <email address hidden>
Date: Tue Jan 24 16:04:48 2023 -0500

    Add userID and userKey to rbd/cephfs secrets

    To create a new RBD volume snapshot the userID and userKey fields
    are required in the RBD secret. These fields are required by
    csi-snapshotter container in the rbd-provisioner pod.

    Official examples show that the RBD secrets need userID and userKey
    fields, while cephfs needs adminID and adminKey required
    for dynamically provisioned volumes and userID and userKey required
    for statically provisioned volumes. That's why these fields were also
    added in cephfs secret.

    Test Plan:
    PASS: Create RBD volume snapshot and check if it's ready to use.
    PASS: Restore RBD volume snapshot.
    PASS: Create Cephfs volume snapshot and check if it's ready to use.
    PASS: Restore Cephfs volume snapshot.

    Closes-bug: 2003907

    Signed-off-by: Hediberto Cavalcante da Silva <email address hidden>
    Change-Id: If526d8412f71da936a66ab783c5919bba0c6611d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/platform-armada-app/+/877563

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/platform-armada-app/+/877563
Committed: https://opendev.org/starlingx/platform-armada-app/commit/6033f687b11e9b69210dae73879ea8502fb25465
Submitter: "Zuul (22348)"
Branch: master

commit 6033f687b11e9b69210dae73879ea8502fb25465
Author: Hediberto Cavalcante da Silva <email address hidden>
Date: Wed Mar 15 19:23:29 2023 -0400

    Updating helmrelease and appversion for ceph-csi

    This change is part of solution to add userID and userKey
    to rbd/cephfs secrets. Updating helmrelease and appvesion for
    stx-rbd-provisioner and stx-cephfs-provisioner allows changes made
    to patches related to rbd-storage-init and cephfs-storage-init jobs
    can be applied via application-update avoiding an extra manual step.

    This is needed to trigger a new revision on stx-rbd-provisioner and
    stx-cephfs-provisioner during helm upgrade.

    Test Plan:
    PASS: build platform-helm, python3-k8sapp-platform and stx-platform-helm
          packages successfully.
    PASS: secrets updated after apply using application-update.
    PASS: new revision was released.

    Partial-bug: 2003907

    Depends-On: https://review.opendev.org/c/starlingx/platform-armada-app/+/871789

    Signed-off-by: Hediberto Cavalcante da Silva <email address hidden>
    Change-Id: Ie4427bdc801c07c170e87dddb35018c9edc64efa