Preset of legacy driver not working for controller-1 on standard lab

[Caio Bruchert]

Brief Description

After installing a standard system 2+2 with the driver bundle set to legacy through the DM file, the correct driver version is loaded on controller-0 and worker nodes, but not on controller-1.

Controller-1 info after installation:

===================
Controller-1sysadmin@controller-1:~$ ethtool -i ens787f2
driver: i40e
version: 2.20.12
firmware-version: 8.20 0x80009b96 1.2879.0
expansion-rom-version:
bus-info: 0000:81:00.2
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
sysadmin@controller-1:~$ ethtool -i ens786f2
driver: i40e
version: 2.20.12
firmware-version: 8.20 0x80009b96 1.2879.0
sysadmin@controller-1:~$ cat /boot/efi/EFI/BOOT/boot.env
cat /proc/cmdline
# GRUB Environment Block
ab=0
boot_tried_count=0
ostree_console= console=ttyS0,115200 console=tty1
default=0
kernel_params= intel_iommu=off usbcore.autosuspend=-1 loop.max_part=15 nmi_watchdog=panic,1 softlockup_panic=1 selinux=0 enforcing=0 softdog.soft_panic=1 systemd.unified_cgroup_hierarchy=0 user_namespace.enable=1 biosdevname=0 nopti nospectre_v2 nospectre_v1####################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################net.naming-scheme=vSTX7_0 BOOT_IMAGE=/1/vmlinuz-5.10.0-6-amd64 rw rootwait ostree_boot=LABEL=otaboot ostree_root=/dev/mapper/cgts--vg-root--lv rd.lvm.lv=cgts/root-lv ostree_var=/dev/mapper/cgts--vg-var--lv ostree=/ostree/1 console=ttyS0,115200 console=tty1 intel_iommu=off usbcore.autosuspend=-1 loop.max_part=15 nmi_watchdog=panic,1 softlockup_panic=1 selinux=0 enforcing=0 softdog.soft_panic=1 systemd.unified_cgroup_hierarchy=0 user_namespace.enable=1 biosdevname=0 crashkernel=2048M apparmor=0 security=apparmor

Severity

<Major: System/Feature is usable but degraded>

Steps to Reproduce

Install standard lab with driver version set through DM file.

On the DM file, add the following parameter:

   serviceParameters:
    - service: platform
      section: config
      paramname: intel_nic_driver_version
      paramvalue: "cvl-2.54"

Expected Behavior

Lab is installed successfully and driver versions loaded are the legacy ones:

Actual Behavior

Lab is installed successfully but controller-1 does not load the correct driver version and the multidriver flag is not present in the /boot/efi/EFI/BOOT/boot.env file

Reproducibility

Reproducible

Tested two times on wildcat-7-10 installation.

System Configuration

Standard

Last Pass

First time testing on standard system. On AIO-SX the test passed.

Timestamp/Logs

Controller-1 info after installation:

===================
Controller-1sysadmin@controller-1:~$ ethtool -i ens787f2
driver: i40e
version: 2.20.12
firmware-version: 8.20 0x80009b96 1.2879.0
expansion-rom-version:
bus-info: 0000:81:00.2
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes
sysadmin@controller-1:~$ ethtool -i ens786f2
driver: i40e
version: 2.20.12
firmware-version: 8.20 0x80009b96 1.2879.0sysadmin@controller-1:~$ cat /boot/efi/EFI/BOOT/boot.env
cat /proc/cmdline
# GRUB Environment Block
ab=0
boot_tried_count=0
ostree_console= console=ttyS0,115200 console=tty1
default=0
kernel_params= intel_iommu=off usbcore.autosuspend=-1 loop.max_part=15 nmi_watchdog=panic,1 softlockup_panic=1 selinux=0 enforcing=0 softdog.soft_panic=1 systemd.unified_cgroup_hierarchy=0 user_namespace.enable=1 biosdevname=0 nopti nospectre_v2 nospectre_v1####################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################net.naming-scheme=vSTX7_0 BOOT_IMAGE=/1/vmlinuz-5.10.0-6-amd64 rw rootwait ostree_boot=LABEL=otaboot ostree_root=/dev/mapper/cgts--vg-root--lv rd.lvm.lv=cgts/root-lv ostree_var=/dev/mapper/cgts--vg-var--lv ostree=/ostree/1 console=ttyS0,115200 console=tty1 intel_iommu=off usbcore.autosuspend=-1 loop.max_part=15 nmi_watchdog=panic,1 softlockup_panic=1 selinux=0 enforcing=0 softdog.soft_panic=1 systemd.unified_cgroup_hierarchy=0 user_namespace.enable=1 biosdevname=0 crashkernel=2048M apparmor=0 security=apparmor

Alarms

NA

Test Activity

Feature testing

Workaround

Manually switch the driver version to default and then back to legacy. After this, the legacy driver is correctly loaded on controller-1

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Caio Bruchert <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/config/+/868509
Reason: After fixing puppet code, this change is not needed anymore. Please see: https://review.opendev.org/c/starlingx/stx-puppet/+/868508

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/868508
Committed: https://opendev.org/starlingx/stx-puppet/commit/3b9d56467a28bedd0a1f55b68317a3c706f0acf0
Submitter: "Zuul (22348)"
Branch: master

commit 3b9d56467a28bedd0a1f55b68317a3c706f0acf0
Author: Caio Bruchert <email address hidden>
Date: Fri Dec 23 16:06:55 2022 -0300

    Fix multi-driver for standard mode via DM file

    When installing a standard system with the intel_nic_driver_version
    service parameter set through DM file, the correct driver was not
    loaded for controller-1.
    This was happening because the puppet configuration for the kernel boot
    parameters was not being called for non-worker nodes.

    Test plan:
    PASS: install standard system using DM file
    PASS: install DX system using DM file
    PASS: install SX system using DM file

    Closes-Bug: 2003536

    Signed-off-by: Caio Bruchert <email address hidden>
    Change-Id: I021f4189ba04391146d2bdd9f84f2437c35115ae