Incorrect .ostree_repo_checksum location on transfer from system controller to subcloud

[Kyle MacLeod]

Brief Description
-----------------

The .ostree_repo_checksum file is transferred into the {{ prestage_dir }}/ostree_repo directory during prestaging operation. It should be transferred into the {{ prestage_dir }} directory instead.

Severity
-----------------

Minor

Steps to Reproduce
-----------------

Perform subcloud prestaging

Install subcloud

Expected Behavior
-----------------

The .ostree_repo_checksum file should be used to verify the ostree_repo content.

On the subcloud we expect to see:

    /opt/platform_backup/ostree_repo
    /opt/platform_backup/.ostree_repo_checksum

Actual Behavior
-----------------

On the subcloud we see:

    /opt/platform_backup/ostree_repo
    /opt/platform_backup/ostree_repo/.ostree_repo_checksum

Since the .ostree_repo_checksum file will be deemed "missing" by the miniboot.cfg kickstart, it will resort to a full ostree fsck. This is more time-consuming.

Reproducibility
-----------------

Reproducible

System Configuration
-----------------

DC

Load info (eg: 2022-03-10_20-00-07)
-----------------

Starlingx master

Last Pass
-----------------

n/a

Timestamp/Logs
-----------------

n/a

Alarms
-----------------

n/a

Test Activity
-----------------

Feature testing

Workaround
-----------------

Manually move the checksum file on the subcloud before installation:

sudo mv /opt/platform_backup/ostree_repo/.ostree_repo_checksum /opt/platform_backup/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ansible-playbooks/+/870870

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ansible-playbooks/+/870870
Committed: https://opendev.org/starlingx/ansible-playbooks/commit/7c91d70827297ef7a65352fa0c211c12383ae2ae
Submitter: "Zuul (22348)"
Branch: master

commit 7c91d70827297ef7a65352fa0c211c12383ae2ae
Author: Kyle MacLeod <email address hidden>
Date: Tue Jan 17 15:22:08 2023 -0500

    Fix incorrect top-level directory for .ostree_repo_checksum

    This commit adjusts the subcloud destination for the
    .ostree_repo_checksum file during prestaging. The proper place for the
    checksum file is at the same level as the ostree_repo directory, not
    inside it.

    Test Plan

    PASS - Peform subcloud prestaging. Verify that the checksum file is
    transferred to /opt/platform-backup/.ostree_repo_checksum rather than
    /opt/platform-backup/ostree_repo/.ostree_repo_checksum.

    PASS - Install subcloud from prestaged data. Ensure the checksum
    is properly found and used, avoiding the ostree fsck.

    Closes-Bug: 2003123

    Change-Id: I43cfade386c11999e8930f9c945ad25de0b61be6
    Signed-off-by: Kyle MacLeod <email address hidden>