Improve <ceph-mon-modify> command output
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
Gabriel de Araújo Cabral |
Bug Description
Brief Description
-----------------
The following command modifies the value for both controllers and also for any other node (compute/storage):
$ system ceph-mon-modify controller-0 ceph_mon_
Although I don't understand the reason we need to inform the controller-
Requests:
1. Can this NOTE be updated to something like: "ceph_mon_gib for hosts are changed"?
2. Also, maybe we can take the opportunity and update the "please follow...." part as well.
According to the guide, we only need to lock/unlock the nodes. My suggestion is to update this message to something like "you must lock and then unlock the host to complete configuring system" instead of asking the operator to open the guide.
Severity
--------
Minor
Steps to Reproduce
------------------
1. Use the ceph-mon-modify command on Storage/Standard lab
Expected Behavior
------------------
Request 1: The note informing the value has been updated for the storage/compute node as well.
Request 2: Also, instead of asking the operator to open the guide to complete the configuration, simply say the affected nodes need to be locked/unlocked.
Actual Behavior
----------------
Request 1: NOTE informing the value has been updated for both controllers only.
Request 2: Instruct the operator to open the guide to check that needs to lock/unlock.
Reproducibility
---------------
100%
System Configuration
-------
Standard/Storage
Branch/Pull Time/Commit
-------
Load: 2022-06-04_20-00-09
Workaround
----------
NA
Changed in starlingx: | |
assignee: | nobody → Gabriel de Araújo Cabral (g-cabral) |
Changed in starlingx: | |
status: | New → In Progress |
tags: | added: stx.storage |
Changed in starlingx: | |
importance: | Undecided → Low |
tags: | added: stx.8.0 |
Reviewed: https:/ /review. opendev. org/c/starlingx /config/ +/869685 /opendev. org/starlingx/ config/ commit/ 888727bbde99eae 3ce6fc31d390fa7 fd437fdf8c
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 888727bbde99eae 3ce6fc31d390fa7 fd437fdf8c
Author: Gabriel de Araújo Cabral <email address hidden>
Date: Mon Jan 9 09:04:21 2023 -0500
Improve <ceph-mon-modify> command output
The 'system ceph-mon-modify <controller> mon_gib= <value> ' command modifies the value not just for
ceph_
both controllers as the last output message was appointing. Now
the text is more appropriate and less redundant.
Test Plan:
PASS: Command <ceph-mon-modify> checked in storage
PASS: Command <ceph-mon-modify> checked in standard
Closes-Bug: 2002416
Signed-off-by: Gabriel de Araújo Cabral <email address hidden> 29ee92943f1cdd8 2578da993c5
Change-Id: Ic3ab8af422b114