Platform-integ-apps doesn't keep user overrides during upgrades

[Dan Voiculeasa]

Brief Description
-----------------
When upgrading from stx.5.0 to stx.6.0 user overrides for platform-integ-apps are lost. This is a problem that still exists today.

Severity
--------
Critical: Requires manual intervention

Steps to Reproduce
------------------
Upgrade stx.<N>.0 to stx.<N+1>.0, where N>=5, before upgrading create user overrides for platform-integ-apps

Expected Behavior
------------------
User overrides for platform-integ-apps are kept.

Actual Behavior
----------------
User overrides for platform-integ-apps are lost.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------
N/A

Timestamp/Logs
--------------
on N version

| user_overrides | classes: |
| | - additionalNamespaces: |
| | - default |
| | - kube-public |
| | - test-namespace |
| | chunk_size: 64 |
| | crush_rule_name: storage_tier_ruleset |
| | name: general |
| | pool_name: kube-rbd |
| | replication: 1 |
| | userId: ceph-pool-kube-rbd |
| | userSecretName: ceph-pool-kube-rbd |
| | |
+--------------------+-----------------------------------------------------+

on N+1

| user_overrides | None |
+--------------------+-----------------------------------------------------+

Test Activity
-------------
Production

Workaround
----------
Save overrides before upgrade-activate step, apply overrides after upgrade-activate step.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/platform-armada-app/+/869553

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/platform-armada-app/+/869553
Committed: https://opendev.org/starlingx/platform-armada-app/commit/e29fbbadbd322ff369d455ece3e83f2992240b4c
Submitter: "Zuul (22348)"
Branch: master

commit e29fbbadbd322ff369d455ece3e83f2992240b4c
Author: Dan Voiculeasa <email address hidden>
Date: Mon Jan 9 12:49:07 2023 +0200

    Keep user overrides during app update

    It was observed when updating the app part of platform upgrade that
    it loses user overrides. I suspect a day 0 slip. All the other apps
    already have a flag enabled to keep the user overrides during
    app updates.

    Enable 'maintain_user_overrides' flag, if present on N+1 version then it
    will keep the N version user overrides.

    If there are any kind of user overrides that need transformation
    between N->N+1 update, these must be handled in the upgrade scripts,
    helm charts or in the lifecycle hooks(maybe create new lifecycle
    hook for this purpose).

    Tests:
    PASS: tested stx.5.0 to stx.6.0 upgrade, with patched
          platform-integ-apps, user overrides are kept

    Closes-Bug: 2002301
    Signed-off-by: Dan Voiculeasa <email address hidden>
    Change-Id: I8d9563519129372e35d328942813256f1a3c1e38