Horizon showing incomplete pop-up message when deleting Orchestration Strategy

[Enzo Candotti]

Brief Description

The following pop-up message appears when we delete an orchestration strategy via Horizon. Looks like it missing some information.

You have selected: . Please confirm your selection.

Severity

Minor.

Steps to Reproduce

    Create/Apply Patch Orchestration Strategy
    Delete the Strategy via Horizon

Expected Behavior

Proper pop-up message

Actual Behavior

Incomplete message.

Reproducibility

1/1

System Configuration

All systems

Last Pass

NA

Timestamp/Logs

NA

Alarms

None.

Test Activity

Testing.

Workaround

NA

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/upstream/+/868933

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/upstream/+/868933
Committed: https://opendev.org/starlingx/upstream/commit/feb152c085dd5a22e929244c481870b27e23759d
Submitter: "Zuul (22348)"
Branch: master

commit feb152c085dd5a22e929244c481870b27e23759d
Author: Enzo Candotti <email address hidden>
Date: Fri Dec 30 18:06:03 2022 -0300

    Fix incomplete pop-up message on delete Action

    When an Action table is created with a 'danger' action_type and a
    single handler method for a single object, the 'selection' and
    'help' parameters are empty. This causes the pop-up message to be
    incomplete. For example:

    "You have selected: . Please confirm your selection. "

    This patch fixes this behaviour by displaying the message with
    the selected objects only when one or more objects are selected.
    Otherwise, it only asks for confirmation.

    Closes-Bug: 2000799

    Test Plan:
    PASS: Build python3-django-horizon package including these changes.
    PASS: Test the behaviour for single delete actions. For example:
    Create a patch strategy and press the "Delete" action. Verify
    the following message is displayed in the pop-up message:
    "Please confirm your selection. This action cannot be undone."

    PASS: Test the behaviour for multiple delete actions. For example:
    Upload more than one patch, select them and click on the 'Delete'
    action. Verify the following message is displayed:
    You have selected: "22.12_NRR_INSVC", "22.12_RESTART_FAILURE_INSVC".
    Please confirm your selection. This action cannot be undone.

    Signed-off-by: Enzo Candotti <email address hidden>
    Change-Id: I85bc5c8155466e14a1a5fa84d54ed22032437f88