User unable to add a VF type interface including the --max-tx-rate parameters from Horizon

[Lucas Ratusznei Fonseca]

Brief Description
-----------------
On an unlocked AIO-SX system the feature description suggests that the interface should be able to be added with max-tx-rate.
There is not place in the Add interface dialog to specify the max-tx-rate.

Severity
--------
Minor

Steps to Reproduce
------------------
Attempt to create an interfaces on simplex system (unlocked or not) with the max-tx-rate eg. equivalent to the following:
system host-if-add -c pci-sriov controller-0 sriov3 vf sriov0 -N 4 --vf-driver=vfio --max-tx-rate 450
eg. In Horizon Create Interface dialog, specify
Interface name
Interface class : pci-sriov
Interface Type: vf
VF Driver eg. vfio (or select netdevice)
Select Interface eg. sriov0
Select the data network
Attempt to specify the max tx rate

Expected Behavior
------------------
Expect to be able to do the equivalent of the cli command

Actual Behavior
----------------
max tx rate can not be set

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
AIO-SX

Branch/Pull Time/Commit
-----------------------
N/A

Last Pass
---------
N/A

Timestamp/Logs
--------------

Test Activity
-------------
Regression

Workaround
----------
Have to lock the host to update this if the interface after creating interface in Horizon

$ system host-if-modify -r 450 controller-0 2be4739d-7d34-416d-b7e9-c0a6d42c99b2
{+}-----------------{-}{-}{+}-------------------------------------+
|Property|Value|

{+}-----------------{-}{-}{+}-------------------------------------+
|ifname|sriov7|
|iftype|vf|
|ports|[]|
|imac|68:05:ca:3a:16:d3|
|imtu|600|
|ifclass|pci-sriov|
|ptp_role|none|
|aemode|None|
|schedpolicy|None|
|txhashpolicy|None|
|primary_reselect|None|
|uuid|2be4739d-7d34-416d-b7e9-c0a6d42c99b2|
|ihost_uuid|c41fd071-ac75-4a28-b905-5d4011c2e9d5|
|vlan_id|None|
|uses|[u'sriov0']|
|used_by|[]|
|created_at|2021-06-08T13:09:36.046345+00:00|
|updated_at|2021-06-08T13:22:39.651421+00:00|
|sriov_numvfs|4|
|sriov_vf_driver|vfio|
|max_tx_rate|450|
|accelerated|[True]|
{+}-----------------{-}{-}{+}--------------------

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/gui/+/868766

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/868766
Committed: https://opendev.org/starlingx/gui/commit/5e81ff87102bfe3aa753fb36707fc0ca5b036ac2
Submitter: "Zuul (22348)"
Branch: master

commit 5e81ff87102bfe3aa753fb36707fc0ca5b036ac2
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Wed Dec 28 11:49:57 2022 -0300

    Allow max_tx_rate config on Horizon

    There was no field in the Horizon interface dialogs to specify the
    max-tx-rate. This commit adds the max_tx_rate field to the Add,
    Modify and Details dialogs.

    Test plan

    PASS Add interface with max_tx_rate set to 100
    PASS Add interface with max_tx_rate set to 0
    PASS Add interface with max_tx_rate set to empty
    PASS Modify interface with max_tx_rate previously set to 100, changing it to 200
    PASS Modify interface with max_tx_rate previously set to 100, changing it to 0
    PASS Modify interface with max_tx_rate previously set to 100, changing it to empty
    PASS Modify interface with max_tx_rate previously set to 0, changing it to 100
    PASS Modify interface with max_tx_rate previously set to 0, changing it to empty
    PASS View details of interface with max_tx_rate set to 0
    PASS View details of interface with max_tx_rate set to 100
    PASS View details of interface with max_tx_rate set to empty

    Closes-Bug: #2000635

    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>
    Change-Id: I16ce1dbd2dbf12367ed6a4428216ad37b4c31f14