New version of shellcheck (0.9.0) causing failures in unrelated changes

[Bob Church]

Brief Description
-----------------
Review submissions now blowing up in unrelated code areas:

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 144:
    local SAVEDLOGS=/var/log/puppet/first_apply.tgz
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 145:
    if [ ! -f ${SAVEDLOGS} ]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 147:
        tar czf ${SAVEDLOGS} ${LOGDIR} 2>/dev/null
        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 148:
        chmod 600 ${SAVEDLOGS}
        ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 153:
    if [ -d ${FILEBUCKET_PATH} ]; then
    ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
       ^-----------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In /home/zuul/src/opendev.org/starlingx/stx-puppet/puppet-manifests/src/bin/puppet-manifest-apply-ignore-warnings.sh line 154:
        rm -fr ${FILEBUCKET_PATH}/*
        ^-------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

Severity
--------
Provide the severity of the defect.
<Critical: System/Feature is not usable due to the defect>
<Major: System/Feature is usable but degraded>
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
Submit a review and observe new noise

Expected Behavior
------------------
Expecting code that wasn't changes and previously passed checks to no be flagged

Actual Behavior
----------------
Infrastructure uprev now flags new errors

Reproducibility
---------------
100%

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Code submission

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/868059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/868059
Committed: https://opendev.org/starlingx/stx-puppet/commit/aca22622ef006c4970428ae949110e3b81aebf9c
Submitter: "Zuul (22348)"
Branch: master

commit aca22622ef006c4970428ae949110e3b81aebf9c
Author: Robert Church <email address hidden>
Date: Mon Dec 19 01:40:35 2022 -0600

    Ignore new shellcheck version (0.9.0) warnings

    Ignore new warning:
     - SC2317: Command appears to be unreachable. Check usage (or ignore if
               invoked indirectly).

    Change-Id: I1fd6b1637785e761ec114b2083531ebddb0085ff
    Closes-Bug: #2000053
    Signed-off-by: Robert Church <email address hidden>