kublet upgrade fails on a worker node

[Bob Church]

Brief Description
-----------------
When attempting to upgrade kubernetes on a worker node the following error occurs

2022-12-18T23:04:42.862 Debug: 2022-12-18 23:04:41 +0000 Exec[mask kubelet for worker upgrade]: Adding default for path
2022-12-18T23:04:42.864 Error: 2022-12-18 23:04:41 +0000 Syntax error at '4' (line: 1, column: 6) on node compute-0
2022-12-18T23:04:42.866 /usr/lib/ruby/vendor_ruby/puppet/pops/parser/parser_support.rb:133:in `on_error'
2022-12-18T23:04:42.868 /usr/lib/ruby/vendor_ruby/puppet/pops/parser/lexer2.rb:708:in `scan'
2022-12-18T23:04:42.870 (eval):3:in `_racc_yyparse_c'
2022-12-18T23:04:42.872 (eval):3:in `yyparse'
2022-12-18T23:04:42.874 /usr/lib/ruby/vendor_ruby/puppet/pops/parser/parser_support.rb:246:in `_parse'
2022-12-18T23:04:42.876 /usr/lib/ruby/vendor_ruby/puppet/pops/parser/parser_support.rb:140:in `parse_string'

Severity
--------
Provide the severity of the defect.
<Critical: System/Feature is not usable due to the defect>
<Major: System/Feature is usable but degraded>
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
------------------
Write down the steps to reproduce the issue

Expected Behavior
------------------
Write down what was expected after taking the steps written above

Actual Behavior
----------------
State what is the actual behavior

Reproducibility
---------------
<Reproducible/Intermittent/Seen once>
State if the issue is 100% reproducible, intermittent or seen once. If it is intermittent, state the frequency of occurrence

System Configuration
--------------------
<One node system, Two node system, Multi-node system, Dedicated storage, https, IPv4, IPv6 etc.>

Branch/Pull Time/Commit
-----------------------
Branch and the time when code was pulled or git commit or cengn load info

Last Pass
---------
Did this test scenario pass previously? If so, please indicate the load/pull time info of the last pass.
Use this section to also indicate if this is a new test scenario.

Timestamp/Logs
--------------
Attach the logs for debugging (use attachments in Launchpad or for large collect files use: https://files.starlingx.kube.cengn.ca/)
Provide a snippet of logs here and the timestamp when issue was seen.
Please indicate the unique identifier in the logs to highlight the problem

Test Activity
-------------
[Sanity, Feature Testing, Regression Testing, Developer Testing, Evaluation, Other - Please specify]

Workaround
----------
Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/868055

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/868055
Committed: https://opendev.org/starlingx/stx-puppet/commit/f82d4b244964d11f86350613591661f4e518b630
Submitter: "Zuul (22348)"
Branch: master

commit f82d4b244964d11f86350613591661f4e518b630
Author: Robert Church <email address hidden>
Date: Mon Dec 19 00:12:04 2022 -0600

    Fix platform::kubernetes::worker::upgrade_kubelet

    Inadvertent variable placement broke the puppet parser for runtime
    manifest execution of platform::kubernetes::worker::upgrade_kubelet.
    Move the variable to top of the class an re-establish the proper exec
    dependencies.

    Test Plan:
    PASS - Modify the manifest on a failed worker node and confirm
           that the upgrade completes

    Signed-off-by: Robert Church <email address hidden>
    Closes-Bug: #2000043
    Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/868059
    Change-Id: I014a086e71189673e8516b3d7db3257556c4bdb9