On multi-node lab that has been upgraded, sw-manager patch-strategy apply to install NRR_INSVC.patch failed

[Jessica Castelino]

Brief Description
-----------------
On multi-node lab that has been upgraded, sw-manager patch-strategy apply NRR_INSVC.patch failed

Severity
-----------------
Major

Steps to Reproduce
-----------------
Upgrade to a newer version(didn't delete old 22.06 load)
upload and apply NRR_INSVC.patch
sw-manager patch-strategy apply

Expected Behavior
-----------------
sw-manager patch-strategy apply succeeds to install the patch

Actual Behavior
-----------------
sw-manager patch-strategy apply to install NRR_INSVC.patch failed

Reproducibility
-----------------
Not sure

System Configuration
-----------------
Duplex

Branch/Pull Time/Commit
-----------------
2022-12-14_22-00-10

Last Pass
-----------------
Not sure

Timestamp/Logs
-----------------
[sysadmin@controller-0 ~(keystone_admin)]$ sw-patch query

Patch ID RR Release Patch State
========= == ======= =============
NRR_INSVC N 22.12 Partial-Apply
PATCH_0001 Y 22.06 Applied
PATCH_0002 Y 22.06 Applied

[sysadmin@controller-0 ~(keystone_admin)]$ sw-manager patch-strategy show

Strategy Patch Strategy:
  strategy-uuid: a75d6b6a-aedc-4468-b26c-30c3514b1119
  controller-apply-type: serial
  storage-apply-type: serial
  worker-apply-type: parallel
  max-parallel-worker-hosts: 10
  default-instance-action: stop-start
  alarm-restrictions: relaxed
  current-phase: abort
  current-phase-completion: 100%
  state: aborted
  apply-result: timed-out
  apply-reason:
  abort-result: success
  abort-reason:

Test Activity
-----------------
Feature Testing

Workaround
-----------------
Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/867903

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/867903
Committed: https://opendev.org/starlingx/update/commit/f257849fa64df324189ae435ebc484a59b8f8cb1
Submitter: "Zuul (22348)"
Branch: master

commit f257849fa64df324189ae435ebc484a59b8f8cb1
Author: Jessica Castelino <email address hidden>
Date: Thu Dec 15 21:24:11 2022 +0000

    Skip older feed release directories if they aren't ostrees

    After a system is upgraded, until we delete the load, the older
    version release folder continues to exist in the env. This commit
    adds a check to skip such folders that aren't ostree repos so
    that we can continue to sync feed repos.

    Test Plan:
    [PASS] Upgrade a system and apply an in-service patch

    Closes-Bug: 1999825
    Signed-off-by: Jessica Castelino <email address hidden>
    Change-Id: I8e551efdf3aa7d527f4016485e4c52b5ad19a9e7