Add error checking to worker_reserved.conf handling

Bug #1999561 reported by Eric MacDonald
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Eric MacDonald

Bug Description

Brief Description
-----------------
A case was seen in the miniboot kickstart where the sed command that updates /etc/platform/worker_reserved.conf failed due to an issue with the
/etc/platform/worker_reserved.conf file.

This was seen in only one redfish subcloud install on one specific server.
Same server was reinstalled multiple times without seeing the issue again.

This update adds some checking around the file creation and sed execution
and fails the install in place if there is an error found. This way the
issue can be debugged to a root cause.

Severity
--------
Critical when it happens

Steps to Reproduce
------------------
Install a subcloud using redfish/rvmc/miniboot

Expected Behavior
------------------
Install succeeds

Actual Behavior
----------------
Install fails

Reproducibility
---------------
Seen only once.

System Configuration
--------------------
Subcloud install using miniboot

Branch/Pull Time/Commit
-----------------------
BUILD_DATE="2022-12-10 03:00:10 +0000"

Last Pass
---------
Frequently passes ; this issue tracks a one-of event

Timestamp/Logs
--------------
2022-12-12 10:19:50.118 miniboot post info: All-in-one All-in-one Reserved Memory: 14500
sed: can't read /etc/platform/worker_reserved.conf: No such file or directory
grep: /etc/platform/worker_reserved.conf: No such file or directory

2022-12-12 10:19:50.125 miniboot post info: All-in-one All-in-one ''

sed: can't read /etc/platform/worker_reserved.conf: No such file or directory
grep: /etc/platform/worker_reserved.conf: No such file or directory

2022-12-12 10:19:50.138 miniboot post info: All-in-one All-in-one ''

Test Activity
-------------
Regression Testing

Workaround
----------
Retry

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/867562

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/c/starlingx/metal/+/867562
Committed: https://opendev.org/starlingx/metal/commit/af7defe48f627bc97698e0d9c59de9c86e2b0be7
Submitter: "Zuul (22348)"
Branch: master

commit af7defe48f627bc97698e0d9c59de9c86e2b0be7
Author: emacdona <email address hidden>
Date: Tue Dec 13 14:34:26 2022 -0500

    Add error checking to worker_reserved.conf handling

    This update add error checking and error handling to
    worker_reserved.conf update handling.

    Test Plan:

    PASS: Verify kickstart logging around worker_reserved
          update for each of the install cases below.
    PASS: Verify subcloud install
    PASS: Verify All In One controller install
    PASS: Verify worker only install
    PASS: Verify standard Controller install

    Closes-Bug: 1999561
    Signed-off-by: emacdona <email address hidden>
    Change-Id: I7ccdd9cc02908fcb0fe0a403c2b2141bd44b692a

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/867828

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/c/starlingx/metal/+/867828
Committed: https://opendev.org/starlingx/metal/commit/97ccd3d9628cd9e1614e8e0d0d1bd5d659e53fd8
Submitter: "Zuul (22348)"
Branch: master

commit 97ccd3d9628cd9e1614e8e0d0d1bd5d659e53fd8
Author: emacdona <email address hidden>
Date: Thu Dec 15 11:56:55 2022 -0500

    Fix bug in recent worker_reserved.conf handling

    The new TEMPLATE_FILE and TARGET_FILE is out of
    scope for work installs.

    Test Plan:

    PASS: Verify worker only install

    Closes-Bug: 1999561
    Signed-off-by: emacdona <email address hidden>
    Change-Id: Id6ce9e773a208637a32d355e6a0bfb3745437eaa

Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
assignee: nobody → Eric MacDonald (rocksolidmtce)
tags: added: stx.8.0 stx.metal
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.