Bad disk configuration when it's an NVMe disk

Bug #1999088 reported by Erickson Silva de Oliveira
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Erickson Silva de Oliveira

Bug Description

Brief Description
-----------------
The issue was not confirmed on hardware, but it most likely exists based on inspection of the code. The current version of partition_info.sh was run from a shell on a previously installed system with NVMe drivers and has runtime errors.

Introduced by
https://review.opendev.org/c/starlingx/config/+/864801
https://review.opendev.org/c/starlingx/config/+/866815

Severity
--------
Critical

Steps to Reproduce
------------------
Run the script passing the disk path.
e.g.: ./partition_info.sh /dev/disk/by-path/pci-0000:b2:05.5-pci-10000:01:00.0-nvme-1

Expected Behavior
------------------
Should work

Actual Behavior
----------------
Fails

Reproducibility
---------------
100%

Branch/Pull Time/Commit
-----------------------
Dec 6 2022

Timestamp/Logs
--------------
$ sudo ./partition_info.sh /dev/disk/by-path/pci-0000:02:00.0-nvme-1
./partition_info.sh: line 55: * 512 / (1024*1024): syntax error: operand expected (error token is "* 512 / (1024*1024)")

Workaround
----------
None

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/866941

Changed in starlingx:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master)

Reviewed: https://review.opendev.org/c/starlingx/config/+/866941
Committed: https://opendev.org/starlingx/config/commit/611d89efb346a05a38c882344103f262f353500d
Submitter: "Zuul (22348)"
Branch: master

commit 611d89efb346a05a38c882344103f262f353500d
Author: Erickson Silva de Oliveira <email address hidden>
Date: Wed Dec 7 22:08:30 2022 +0000

    Fix the partition_info.sh script

    The issue was not confirmed on hardware, but it most likely exists
    based on inspection of the code. The current version of partition_info.sh
    was run from a shell on a system with NVMe drivers and has runtime errors.

    The problem was introduced by:
    https://review.opendev.org/c/starlingx/config/+/864801
    https://review.opendev.org/c/starlingx/config/+/866815

    Test Plan:
     ./partition_info.sh /dev/disk/by-path/pci-0000:02:00.0-nvme-1

    Closes-Bug: 1999088

    Signed-off-by: Erickson Silva de Oliveira <email address hidden>
    Change-Id: Ie7c2b4d9474090c9ce33ce37687346d005297f97

Changed in starlingx:
status: In Progress → Fix Released
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → High
tags: added: stx.8.0 stx.storage
Changed in starlingx:
assignee: nobody → Erickson Silva de Oliveira (esilvade)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.