first unlock fails due to bad disk setup

[Al Bailey]

Brief Description
-----------------
Unable to unlock a system after running initial bootstrap due to bad disk setup
Introduced by
https://review.opendev.org/c/starlingx/config/+/864801

Severity
--------
Critical

Steps to Reproduce
------------------
Boot/Bootstrap/Unlock

Expected Behavior
------------------
Should work

Actual Behavior
----------------
Fails

Reproducibility
---------------
100%

System Configuration
--------------------
STD

Branch/Pull Time/Commit
-----------------------
Dec 6 2022

Last Pass
---------
Dec 5 2022

Timestamp/Logs
--------------
sysinv 2022-12-06 21:20:53.470 44636 INFO sysinv.conductor.manager [-] Inconsistent Data: Not adding PV: {
'forihostid': 1,
'lvm_pv_name': '/dev/sda5',
'lvm_vg_name': 'cgts-vg',
'lvm_pv_uuid': '5HFI2o-lo9S-ECo4-levW-yAdu-Jygc-SgikPB',
'lvm_pv_size': 502947381248,
'lvm_pe_total': 119912,
'lvm_pe_alloced': 46800}

sysinv 2022-12-06 21:20:54.307 44636 INFO sysinv.conductor.manager [-] Inventory incomplete, will try again in 1 second.
sysinv 2022-12-06 21:20:55.366 44636 INFO sysinv.conductor.manager [-] Inventory incomplete, will try again in 1 second.
sysinv 2022-12-06 21:20:55.737 44636 ERROR sysinv.conductor.manager [-] Updating partition (None) for ipv id failed (1ee16d30-8e1f-4979-bfaf-1d68d98559f1):

Test Activity
-------------
Feature Testing

Workaround
----------
None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/866815

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/866815
Committed: https://opendev.org/starlingx/config/commit/2d0d1c250102899e36c15832bc0583164e5b6966
Submitter: "Zuul (22348)"
Branch: master

commit 2d0d1c250102899e36c15832bc0583164e5b6966
Author: Al Bailey <email address hidden>
Date: Wed Dec 7 01:30:50 2022 +0000

    Fix disk partition determination code

    During initial bootstrap of a system, the disks need the proper
    partition information otherwise the system cannot be provisioned.

    The change from parted to sfdisk introduced a couple of problems
    1) naming pattern for nvme disks was broken
    2) the partition info was using the path rather than device node
    which was returning invalid device numbering.

    The problem was introduced by:
    https://review.opendev.org/c/starlingx/config/+/864801

    Closes-Bug: #1998983

    Test Plan:
     Build/Bootstrap/Unlock a Debian AIO-STD system

    Co-Authored-By: Robert Church <email address hidden>
    Signed-off-by: Al Bailey <email address hidden>
    Change-Id: I59ec68f66c8efee04629d8f3f230d79e467ba8e5