Add Interface Button disappeared after configuring the 8th interface

[Takamasa Takenaka]

Brief Description
-----------------
The Add interface button disappeared after configuring 8 interfaces for controller-1 via GUI

Severity
--------
<Major: System/Feature is usable but degraded>

Steps to Reproduce
------------------
After successfully installing controller-0
We tried configuring the interfaces for controller-1.
The button was working fine till the 8 interface, thereafter it got disappeared.
hence we had to resort to CLI to do the interface configuration.

Expected Behavior
------------------
The Add Interface button should never disappear.

Actual Behavior
----------------
The Add Interface button should disappeared.

Reproducibility
---------------
We didn't reinstall the system multiple times.

System Configuration
--------------------
System Controller (Standard Controller Duplex)

Branch/Pull Time/Commit
-----------------------
N/A

Last Pass
---------
Don't know it seems to be a regression

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Installation on Site

Workaround
----------
We used the CLI to configure below commands.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/gui/+/866380
Committed: https://opendev.org/starlingx/gui/commit/e2c5d33fab8769e85753735ebd54ded56348ba6e
Submitter: "Zuul (22348)"
Branch: master

commit e2c5d33fab8769e85753735ebd54ded56348ba6e
Author: Takamasa Takenaka <email address hidden>
Date: Thu Dec 1 15:51:23 2022 -0300

    Remove unnecessary button visibility logic

    Current logic compares number of interface and number of
    interface type for "Create Interface" button visibility.

    Current interface type defines 4 types, so that if more than
    4 interfaces are configured in any type, "Create Interface"
    will be invisible, which should not.

    This fix is to remove this logic, so that user can add
    interfaces through gui.

    Closes-bug: 1998638

    Test Plan:
    PASS: "Create Interface" button is visible
          after adding 8 interfaces and we can
          add more than 8 interfaces.

    Signed-off-by: Takamasa Takenaka <email address hidden>
    Change-Id: I409a3483d6e0c4e0f53436d02d710b4dcafe2d20