Debian: system registry-garbage-collect fails

[Boovan Rajendran]

Brief Description:

 system registry-garbage-collect fails on Debian load

Severity:

<Minor: System/Feature is usable with minor issue>

Steps to Reproduce:

Deploy system, run 'system registry-garbage-collect'

Expected Behavior:

puppet finishes successfully

Actual Behavior:

puppet doesn't finish successfully

Reproducibility:

100%

System Configuration:

all

Load info (eg: 2022-03-10_20-00-07):

I assume day 0 Debian, but say 23 Nov 2022

Last Pass:

?? Only CentOS passes I assume

Timestamp/Logs:

2022-11-23T17:27:13.513 Error: 2022-11-23 17:27:11 +0000 /Stage[main]/Platform::Dockerdistribution::Garbagecollect/Exec[run garbage collect]/returns: change from 'notrun' to ['0'] failed: Could not find command '/usr/bin/registry'

Alarms:

N/A

Test Activity:

Developer Testing

Workaround:

N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/865949

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/865949
Committed: https://opendev.org/starlingx/stx-puppet/commit/2d7fb7ef34e4b34d3c07097b9b4b2c55a5ec59f2
Submitter: "Zuul (22348)"
Branch: master

commit 2d7fb7ef34e4b34d3c07097b9b4b2c55a5ec59f2
Author: Boovan Rajendran <email address hidden>
Date: Tue Nov 29 02:33:31 2022 -0500

    Debian: Fix system garbage-collect

    On Debian docker registry has moved to /usr/bin/docker-registry.
    Puppet calls a command with the CentOS path, resulting in error.

    Updated a command in the platform::dockerdistribution::garbagecollect
    class to point to correct registry path.

    Test Plan:
    Deployed the ISO with the change as AIO-SX and verified the
    /var/log/puppet/latest/puppet.log file.

    Closes-Bug: 1998183

    Signed-off-by: Boovan Rajendran <email address hidden>
    Change-Id: If001e4294a8de0ff2eed0f4455fb0fe7acff1b6d