Alarm "OS reports vendor or device-id without match on DB for port ens1f1" seen after SX upgrade

[Andre Kantek]

Brief Description
After the upgrade on AIO-SX system(hpe-e920t-016) alarm "OS reports vendor or device-id without match on DB for port ens1f1" was seen and never cleared. Not sure whether it is a valid alarm. This alarm was not seen in the 22.06 build prior to the upgrade.

Severity

Minor

Steps to Reproduce

Follow the upgrade in AIO-SX as per the upgrade procedure.

Expected Behavior

No alarms after the upgrade.

Actual Behavior

As per the description. The alarm was generated and it was not cleared after AIO-SX upgrade. This alarm was not seen after install.

| Alarm ID | Reason Text | Entity ID | Severity | Time Stamp |
+----------+--------------------------------------------------------------------+---------------------------------------+----------+-------------------+
| 300.001 | OS reports vendor or device-id without match on DB for port ens1f1 | port=host=controller-0.port=4020521f- | major | 2022-11-24T21:06: |
| | | fa02-4dcd-9b2f-9091b0c8f6e1 | | 48.953018 |
| | | | | |
| 500.101 | Developer patch certificate is enabled | host=controller | critical | 2022-11-24T21:06: |
| | | | | 34.672660 |
| | | | | |
+----------+--------------------------------------------------------------------+---------------------------------------+----------+-------------------+
Reproducibility
Seen in the latest build lab hpe-e920t-016

System Configuration
AIO-SX hpe-e920t-016

Load info (eg: 2022-03-10_20-00-07)
Debian build "2022-11-23"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/865879

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/865879
Committed: https://opendev.org/starlingx/config/commit/bb3347ac8abae8d2084e8a2e5382c2c349ede236
Submitter: "Zuul (22348)"
Branch: master

commit bb3347ac8abae8d2084e8a2e5382c2c349ede236
Author: Andre Fernando Zanella Kantek <email address hidden>
Date: Mon Nov 28 13:36:50 2022 -0500

    Use numerical ID to compare NIC's vendor and device

    Was detected an ethernet port alarm "300.001: OS reports vendor or
    device-id without a match on DB for port" at the last step of
    upgrade.

    To determine if a different card was inserted we compare: MAC
    address, Device ID and Vendor ID to update the DB. The problem is
    that we are using the entire string to compare.

    The previous CentOS version saved the Device-ID as (e.g.) "Device
    [1593]", but now on Debian the NIC is announcing "Ethernet
    Controller E810-C for SFP [1593]". We need to compare only the
    numerical ID "1593"

    The correction gets only the numerical ID for comparision, discarding
    the description, to make sure to only act if a NIC replacement is
    present.

    A new logic to update only the vendor and/or device description, on
    existing hardware.

    Test Plan
    [PASS] AIO-SX upgrade done in VirtualBox
    [PASS] unit test to cover this case

    Closes-Bug: 1998131

    Signed-off-by: Andre Fernando Zanella Kantek <email address hidden>
    Change-Id: I1b42e68dc81cb96875994d057927aeccf14d4ad7