Incorrect state transition for dcmanager subcloud-backup restore failure

[Tee Ngo]

Brief Description
-----------------
The deploy_status transitions from restoring to restore-prep-failed following a restore failure. The correct state is restore-failed.

Severity
--------
Minor

Steps to Reproduce
------------------
Perform a subcloud restore using dcmanager subcloud-backup command with an induced error.

Expected Behavior
------------------
deploy_status is set to restore-failed

Actual Behavior
----------------
deploy_status is set to restore-prep-failed

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed Cloud

Branch/Pull Time/Commit
-----------------------
2022-11-05 master

Last Pass
---------
Never did

Timestamp/Logs
--------------
Readily reproducible

Test Activity
-------------
Feature Testing

Workaround
----------
None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/864646

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/864646
Committed: https://opendev.org/starlingx/distcloud/commit/949a514c3ffd4828cf355880819574eb814e803d
Submitter: "Zuul (22348)"
Branch: master

commit 949a514c3ffd4828cf355880819574eb814e803d
Author: Tee Ngo <email address hidden>
Date: Tue Nov 15 21:55:43 2022 -0500

    Fix incorrect state transition for subcloud restore

    Currently the state transitions from restoring to restore-prep-failed
    when the restore playbook fails for whatever reason. The right
    state is restore-failed. This commit fixes that.

    Test Plan:
      - Perform a subcloud restore with an induced error using dcmanager
        subcloud-backup restore command. Verify that the deploy_status
        is set to restore-failed upon failing.

    Closes-Bug: 1996673
    Change-Id: I54b84b753ab3484a1853d2a5e7e30ec6067def09
    Signed-off-by: Tee Ngo <email address hidden>