ptp4l instance doesn't assume clockClass=6 due to new label introduced by new ice driver version

Bug #1995302 reported by Teresa Ho
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Medium
Teresa Ho

Bug Description

Brief Description
-----------------
The new ice driver version changed the status text from "locked_ho_ack" to "locked_ho_acq" so collectd isn't reading it correctly. This is preventing ptp4l instance to assume clockClass=6 and may have other effects.

This was found with Logan Beach NIC using ice driver as below:

[sysadmin@controller-0 ~(keystone_admin)]$ ethtool -i enp81s0f2
driver: ice
version: 1.9.11
firmware-version: 4.00 0x800117eb 1.3236.0

The status of GNSS signal used to be "locked_ho_ack", now it is as below:

[root@controller-0 ptpinstance(keystone_admin)]# cat /sys/kernel/debug/ice/0000\:51\:00.0/cgu
Found ZL80032 CGU
DPLL Config ver: 1.3.0.1

CGU Input status:
                   | | priority | |
      input (idx) | state | EEC (0) | PPS (1) | ESync fail |
  ----------------------------------------------------------------
     CVL-SDP22 (0) | invalid | 8 | 8 | N/A |
     CVL-SDP20 (1) | invalid | 15 | 3 | N/A |
  C827_0-RCLKA (2) | invalid | 4 | 4 | N/A |
  C827_0-RCLKB (3) | invalid | 5 | 5 | N/A |
  C827_1-RCLKA (4) | invalid | 6 | 6 | N/A |
  C827_1-RCLKB (5) | invalid | 7 | 7 | N/A |
          SMA1 (6) | invalid | 1 | 1 | N/A |
    SMA2/U.FL2 (7) | invalid | 2 | 2 | N/A |
     GNSS-1PPS (8) | valid | 0 | 0 | N/A |

EEC DPLL:
        Current reference: GNSS-1PPS
        Status: locked_ho_acq

PPS DPLL:
        Current reference: GNSS-1PPS
        Status: locked_ho_acq
        Phase offset [ns]: 11
Severity
--------
<Critical: System/Feature is not usable after the defect>

Steps to Reproduce
------------------
Configure host as a GM with ptp4l, ts2phc and clock instances.

Make sure GNSS signal is available and locked.

Expected Behavior

ptp4l instance should assume clockClass=6 and timeTraceable=1

[sysadmin@controller-0 ~(keystone_admin)]$ sudo pmc -u -b 0 -f /etc/linuxptp/ptpinstance/ptp4l-ptp1.conf -s /var/run/ptp4l-ptp1 'GET GRANDMASTER_SETTINGS_NP'
Password:
sending: GET GRANDMASTER_SETTINGS_NP
    40a6b7.fffe.82101a-0 seq 0 RESPONSE MANAGEMENT GRANDMASTER_SETTINGS_NP
        clockClass 6
        clockAccuracy 0xfe
        offsetScaledLogVariance 0xffff
        currentUtcOffset 37
        leap61 0
        leap59 0
        currentUtcOffsetValid 0
        ptpTimescale 1
        timeTraceable 1
        frequencyTraceable 0
        timeSource 0xa0

Actual Behavior
---------------
ptp4l is clockClass=248 and not timeTraceable

[sysadmin@controller-0 ~(keystone_admin)]$ sudo pmc -u -b 0 -f /etc/linuxptp/ptpinstance/ptp4l-ptp1.conf -s /var/run/ptp4l-ptp1 'GET GRANDMASTER_SETTINGS_NP'
Password:
sending: GET GRANDMASTER_SETTINGS_NP
    40a6b7.fffe.82101a-0 seq 0 RESPONSE MANAGEMENT GRANDMASTER_SETTINGS_NP
        clockClass 248
        clockAccuracy 0xfe
        offsetScaledLogVariance 0xffff
        currentUtcOffset 37
        leap61 0
        leap59 0
        currentUtcOffsetValid 0
        ptpTimescale 1
        timeTraceable 0
        frequencyTraceable 0
        timeSource 0xa0

Reproducibility
---------------
Reproducible

System Configuration
--------------------
AIO-SX + GNSS signal

Branch/Pull Time/Commit
-----------------------
2022-10-26_18-01-09

Last Pass
---------
Test used to pass with the older driver version

Test Activity
-------------
Regression Testing

Workaround
----------
NA

Teresa Ho (teresaho)
Changed in starlingx:
assignee: nobody → Teresa Ho (teresaho)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to monitoring (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/monitoring/+/863095

Changed in starlingx:
status: New → In Progress
Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Medium
tags: added: stx.8.0 stx.networking
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to monitoring (master)

Reviewed: https://review.opendev.org/c/starlingx/monitoring/+/863095
Committed: https://opendev.org/starlingx/monitoring/commit/fc4b019da60e39f79064c3045e2beb537c437519
Submitter: "Zuul (22348)"
Branch: master

commit fc4b019da60e39f79064c3045e2beb537c437519
Author: Teresa Ho <email address hidden>
Date: Mon Oct 31 13:28:27 2022 -0400

    Support new status text in ice driver 1.9.11

    The new ice driver 1.9.11 changed the status text from "locked_ho_ack"
    to "locked_ho_acq". This commit updated PTP monitoring in collectd to
    interpret the new status string as locked state.

    Test Plan:
    PASS: With GNSS locked, ensure that the clockclass is set to 6

    Closes-Bug: 1995302

    Signed-off-by: Teresa Ho <email address hidden>
    Change-Id: I48b447a8c0c16ff912f186a1db3ae4bba69b668d

Changed in starlingx:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.