StarlingX | Puppet error - Duplicate declaration during ansible playbook

[Gabriel Calixto de Paula]

Brief Description
-----------------
When trying to install StarlingX CentOS latest_build for sanity execution, it fails to complete the ansible-playbook failing during the puppet configuration

Severity
--------
Major

Steps to Reproduce
------------------
1. Run the ansible-playbook for stx
Expected Behavior
------------------
It should complete the ansible playbook steps
Actual Behavior
----------------
The ansible playbook fails when configuring puppet
Reproducibility
---------------
Reproducible

System Configuration
--------------------
Two-node system with 4 platform-assigned cores
STX master latest_build 2022-10-21 02:58:54

Timestamp/Logs
--------------
2022-10-21 14:05:57,341 p=11655 u=sysadmin | TASK [bootstrap/apply-manifest : Fail if puppet manifest apply script returns an error] ***
2022-10-21 14:05:57,341 p=11655 u=sysadmin | Friday 21 October 2022 14:05:57 +0000 (0:00:05.458) 0:00:52.027 ********
2022-10-21 14:05:57,368 p=11655 u=sysadmin | fatal: [localhost]: FAILED! => changed=false
  msg: Failed to apply bootstrap manifest. Please re-install host localhost before attempting to bootstrap it again. See /var/log/puppet/latest/puppet.log for details.

2022-10-21T14:05:56.981 ^[[1;31mError: 2022-10-21 14:05:56 +0000 Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Exec[restart-openldap] is already declared in file /usr/share/puppet/modules/platform/manifests/ldap.pp:71; cannot redeclare at /usr/share/puppet/modules/platform/manifests/ldap.pp:120 at /usr/share/puppet/modules/platform/manifests/ldap.pp:120:8

Test Activity
-------------
Sanity

Workaround
----------
N/A

Last Pass
---------
Last week, sanity executed normally

[Al Bailey (albailey1974)]

This is the commit that introduced the issue
https://review.opendev.org/c/starlingx/stx-puppet/+/861275

A duplicate restart-openldap was added (line 71)

[Ghada Khalil (gkhalil)]

screening: stx.8.0 / high - issue preventing the execution of stx-openstack sanity which is still run on top of CentOS

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/862755

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/862755
Committed: https://opendev.org/starlingx/stx-puppet/commit/61268fa191db99f8c27f36fd01f4783c04b9819f
Submitter: "Zuul (22348)"
Branch: master

commit 61268fa191db99f8c27f36fd01f4783c04b9819f
Author: Andy Ning <email address hidden>
Date: Wed Oct 26 12:12:20 2022 -0400

    Fix ldap puppet duplicate declaration error

    On CentOS based STX system, ansible bootstrap will fail to complete
    during puppet configuration. The failure is caused by a duplicate
    declaration error in ldap.pp. This change fixed this error by
    updating ldap.pp to avoid the duplicate declaration.

    TEST PLAN (CentOS only):
    PASS: System deployment (bootstrap and unlock)
    PASS: System lock/unlock
    PASS: Verify openldap user accessibility by
          getent passwd <openldap user>
    PASS: Verify openldap user existance by
          ldapsearch -x -b 'ou=people,dc=cgcs,dc=local' '(objectclass=*)'
    PASS: Verify ldapscripts tools can access openldap users by
          ldapfinger <openldap user>
    PASS: Verify openldap users can login system on console and by ssh

    Closes-Bug: 1993832
    Signed-off-by: Andy Ning <email address hidden>
    Change-Id: Iaf24e5e946eb3ba9f194b1f1c743bec98898b1c4