Failure to add OIDC service parameters

[Jorge Saffe]

Brief Description
-----
OIDC service-parameter-add operation failed with following error.

[sysadmin@controller-1 ~(keystone_admin)]$ system service-parameter-add kubernetes kube_apiserver oidc_client_id="stx-oidc-client-app" This parameter 'oidc_client_id' is deprecated you must use a valid parameter like (oidc-issuer-url, oidc-client-id, oidc-username-claim, oidc-groups-claim).
[sysadmin@controller-1 ~(keystone_admin)]$

Following command is working

[sysadmin@controller-1 ~(keystone_admin)]$ system service-parameter-add kubernetes kube_apiserver oidc-client-id=stx-oidc-client-app
+-------------+--------------------------------------+
| Property | Value |
+-------------+--------------------------------------+
| uuid | d5665e57-2687-4a10-b298-a06e3e847d00 |
| service | kubernetes |
| section | kube_apiserver |
| name | oidc-client-id |
| value | stx-oidc-client-app |
| personality | None |
| resource | None |
+-------------+--------------------------------------+

The add command is working when argument changed from oidc_client_id to oidc-client-id

Severity
----
<Minor: System/Feature is usable with minor issue>

Steps to Reproduce
-----
Manual: Run command system service-parameter-add kubernetes kube_apiserver oidc_client_id="stx-oidc-client-app"

Expected Behavior
-----
System parameter added successfully

Actual Behavior
----
System parameter add operation failed

Reproducibility
----
<Reproducible

Alarms
----
NA

Test Activity
----
Regression Testing

Workaround
----
NA

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/860751

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/860751
Committed: https://opendev.org/starlingx/config/commit/9e956b764f846a81d5d00401ce2f72aec5b3b9a5
Submitter: "Zuul (22348)"
Branch: master

commit 9e956b764f846a81d5d00401ce2f72aec5b3b9a5
Author: Jorge Saffe <email address hidden>
Date: Fri Oct 7 17:25:33 2022 -0400

    Fix failure to add OIDC service parameters

    This changes fix OIDC service-parameter-add
    operation.

    Test Plan:
    * CENTOS and DEBIAN distro:
      - Fresh Install with AIO-SX.
      - Add OIDC service-parameter.
      - Apply changes on kubernetes service.
      - Verify cluster health and configuration.

    Closes-Bug: 1992208

    Signed-off-by: Jorge Saffe <email address hidden>
    Change-Id: I3ecc17606531068a9d2c4371b081c1661d47670f