Reviews failing tox bashate tests in stx/metal

Bug #1991971 reported by Al Bailey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
Low
Al Bailey

Bug Description

Brief Description
-----------------
Reviews in stx/metal are failing zuul due to bashate.
bashate 2.1.1 was released Oct 6, 2022

Severity
--------
Minor

Steps to Reproduce
------------------
tox -e linters

Expected Behavior
------------------
Should pass

Actual Behavior
----------------
Fails (depending on the upper constraints)

Reproducibility
---------------
Intermittent.

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
Oct 6, 2022

Last Pass
---------
Oct 5, 2022

Timestamp/Logs
--------------
/home/zuul/src/opendev.org/starlingx/metal/mtce/src/pmon/scripts/pmon-test.sh:154:1: E003 Indent not multiple of 4
1 bashate error(s) found

Test Activity
-------------
Developer Testing

Workaround
----------
None. The file needs to be updated, or the upper constraints need to be respected

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to metal (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/860596

Changed in starlingx:
status: New → In Progress
Al Bailey (albailey1974)
Changed in starlingx:
assignee: nobody → Al Bailey (albailey1974)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to metal (master)

Reviewed: https://review.opendev.org/c/starlingx/metal/+/860596
Committed: https://opendev.org/starlingx/metal/commit/dd5a24037d1ba91047176b0b95d2f5acf62755eb
Submitter: "Zuul (22348)"
Branch: master

commit dd5a24037d1ba91047176b0b95d2f5acf62755eb
Author: Al Bailey <email address hidden>
Date: Thu Oct 6 17:05:24 2022 +0000

    Fix bashate failure in zuul

    This review allows this repo to pass zuul.

    When tox is run locally it pulls in an older
    bashate 0.6.0 but the zuul jobs are pulling in
    the higher version.

    Bashate 2.1.1 was releated Oct 6, 2022

    Changed the upper constraints to allow developers
    to pull in dependencies that are more aligned with zuul.

    Fixed the new bashate error.
    Also cleaned up the yamllint syntax.

    Closes-Bug: 1991971
    Signed-off-by: Al Bailey <email address hidden>
    Change-Id: I9cda349a20c63f9d222a3c3fc3645c5ceb4c2751

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to integ (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/860728

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to integ (master)

Reviewed: https://review.opendev.org/c/starlingx/integ/+/860728
Committed: https://opendev.org/starlingx/integ/commit/d555f1aae3884dbb4a17c6de176b1baca2897bbc
Submitter: "Zuul (22348)"
Branch: master

commit d555f1aae3884dbb4a17c6de176b1baca2897bbc
Author: Al Bailey <email address hidden>
Date: Fri Oct 7 17:13:44 2022 +0000

    Fix bashate failure in zuul

    This review allows this repo to pass zuul.

    Bashate 2.1.1 was released Oct 6, 2022
    It adds a more stict indentation check

    Fixed the new bashate error.

    Related-Bug: 1991971

    Signed-off-by: Al Bailey <email address hidden>
    Change-Id: I2730f9216b46b3fa2a83f2f8d55ead2b813f4e37

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to utilities (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/utilities/+/860744

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to utilities (master)

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/860744
Committed: https://opendev.org/starlingx/utilities/commit/971f9b6630be36130f7f87556a02d9879d8f8daf
Submitter: "Zuul (22348)"
Branch: master

commit 971f9b6630be36130f7f87556a02d9879d8f8daf
Author: Al Bailey <email address hidden>
Date: Fri Oct 7 19:19:51 2022 +0000

    Fix bashate failure in zuul

    This review allows this repo to pass zuul.

    Bashate 2.1.1 was released Oct 6, 2022
    It adds a more stict indentation check

    Fixed the new bashate error.

    Related-Bug: 1991971

    Signed-off-by: Al Bailey <email address hidden>
    Change-Id: I4e86c2a5046fd7ab876ce8ca0e1ad9e6fdbaaf01

Ghada Khalil (gkhalil)
Changed in starlingx:
importance: Undecided → Low
tags: added: stx.8.0 stx.metal stx.zuul
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.