stx-openstack: lack of hook-weight on stx-admin

[Rafael Falcão]

Brief Description
-----------------
During the identity stx-openstack fluxcd application tests it was noticed that the stx-admin-ks-user job is failing to render properly due some resources dependencies. Those dependencies was being blocked by the stx-admin-ks-user due lack of hook-weight annotation.

Severity
--------
Provide the severity of the defect.
Minor: Application apply always fails. stx-openstack fluxcd app stills in development phase though.

Steps to Reproduce
------------------
* Build the identity stx-openstack fluxcd app (https://review.opendev.org/c/starlingx/openstack-armada-app/+/848162)
* Upload stx-openstack with: system application-upload
* Apply stx-openstack with: system application-apply

Expected Behavior
------------------
stx-openstack (identity) fluxcd application is successfully applied.

Actual Behavior
----------------
stx-openstack (identity) fluxcd application fails to apply.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master + https://review.opendev.org/c/starlingx/openstack-armada-app/+/848162

Last Pass
---------
N/A

Timestamp/Logs
--------------
Attach the logs for debugging (use attachments in Launchpad or for large collect files use: https://files.starlingx.kube.cengn.ca/)
Provide a snippet of logs here and the timestamp when issue was seen.
Please indicate the unique identifier in the logs to highlight the problem

Test Activity
-------------
Entrypoint WARNING: 2022/08/04 15:15:20 entrypoint.go:72: Resolving dependency Job keystone-db-sync in namespace openstack failed: jobs.batch "keystone-db-sync" not found .
Entrypoint WARNING: 2022/08/04 15:15:20 entrypoint.go:72: Resolving dependency Job keystone-credential-setup in namespace openstack failed: jobs.batch "keystone-credential-setup" not found .
Entrypoint WARNING: 2022/08/04 15:15:20 entrypoint.go:72: Resolving dependency Job keystone-fernet-setup in namespace openstack failed: jobs.batch "keystone-fernet-setup" not found .
Entrypoint WARNING: 2022/08/04 15:15:22 entrypoint.go:72: Resolving dependency Job keystone-credential-setup in namespace openstack failed: jobs.batch "keystone-credential-setup" not found .
Entrypoint WARNING: 2022/08/04 15:15:22 entrypoint.go:72: Resolving dependency Job keystone-db-sync in namespace openstack failed: jobs.batch "keystone-db-sync" not found .
Entrypoint WARNING: 2022/08/04 15:15:22 entrypoint.go:72: Resolving dependency Job keystone-fernet-setup in namespace openstack failed: jobs.batch "keystone-fernet-setup" not found .

Workaround
----------
None

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/openstack-armada-app/+/858444

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/openstack-armada-app/+/858444
Committed: https://opendev.org/starlingx/openstack-armada-app/commit/f13d94693fc24a3d899b7183fcc7b0135ea1b14e
Submitter: "Zuul (22348)"
Branch: master

commit f13d94693fc24a3d899b7183fcc7b0135ea1b14e
Author: Rafael Falcão <email address hidden>
Date: Mon Sep 19 16:27:41 2022 -0300

    Making stx_admin (osh) helm v3 compatible

    The patch added by this change will make the stx_admin job
    syntax compatible with FluxCD (helmv3). It is necessary to add
    a hook-weight annotation to the resource to guarantee that all
    required resources will be up and running by the time of the
    job creation.

    Test Plan:
    PASS - build-helm-charts.sh builds a basic FluxCD and a complete Armada
           app tarball
    PASS - application upload and overrides generated
    PASS - application apply and check if the new hooks takes place
    PASS - application remove/delete

    Closes-Bug: 1990188

    Signed-off-by: Rafael Falcao <email address hidden>
    Change-Id: I83137f54eb18ba01b880e093a77b987283e5d907