Debian AIO-SX: multipath service failure during lock-unlock

[Matheus Machado Guilhermino]

Brief Description
------------------
puppet failure during lock-unlock

Severity
---------
Critical

Steps to Reproduce
-------------------
lock-unlock

Expected Behavior
------------------
No puppet failure

Actual Behavior
----------------
Puppet failure

Reproducibility
----------------
100%

System Configuration
---------------------
AIO-SX

Load info
----------
Debian 24th May

Last Pass
----------
-

Timestamp/Logs
---------------
[root@controller-0 sysadmin(keystone_admin)]# cat /var/log/puppet/latest/puppet.log | grep Error:
2022-05-26T09:48:18.043 Error: 2022-05-26 09:48:18 +0000 Systemd start for multipathd failed!
2022-05-26T09:48:18.243 Error: 2022-05-26 09:48:18 +0000 /Stage[main]/Platform::Multipath/Service[start-multipathd]/ensure: change from 'stopped' to 'running' failed: Systemd start for multipathd failed!

Alarms
-------
-

Test Activity
--------------
Developer Testing

Workaround
-----------
Disable puppet code related to multipath

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/858440

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/858440
Committed: https://opendev.org/starlingx/stx-puppet/commit/396be6304c9fc70e4d2852c8bb58ade7a4069939
Submitter: "Zuul (22348)"
Branch: master

commit 396be6304c9fc70e4d2852c8bb58ade7a4069939
Author: Matheus Guilhermino <email address hidden>
Date: Mon Sep 19 14:04:50 2022 -0300

    Fix blacklist on multipath.conf

    Leaving the multipath option enabled on Debian was causing
    the lock-unlock process to fail with an error message pointing
    to the multipath.conf file that stated:
    "error parsing config file"

    The parsing error happens because "*" is not a valid regular
    expression and the solution was simply changing "*" to ".*"

    Test Plan (CentOS & Debian):
    PASS: Build and Install
    PASS: Unlock Controller-0
    PASS: Multiple lock-unlock
    PASS: multipathd service faced no errors

    Closes-bug: 1990183

    Signed-off-by: Matheus Guilhermino <email address hidden>
    Change-Id: I750589d4268fffc9440233014d6c66dbe50ed07a