UEFI installs report grub-install error

[Bob Church]

Brief Description
-----------------
UEFI installs produce a series of grub related messages in the install log:

Installing for i386-pc platform.
/sbin/grub-install: warning: this GPT partition label contains no BIOS Boot Partition; embedding won't be possible.
/sbin/grub-install: warning: Embedding is not possible. GRUB can only be installed in this setup by using blocklists. However, blocklists are UNRELIABLE and their use is discouraged..
/sbin/grub-install: error: will not proceed with blocklists.

We recently aligned the partitioning schemes with previous CentOS releases (to preserve the platform backup partition) and for existing UEFI installs we do not have a BIOS boot partition present.

The LAT installer will attempt to write the legacy BIOS grub information after exiting from the %mkfs hook. We need to skip this as the above messages will be generated

Severity
--------
Minor: The UEFI installs continue to work correctly, but the error message

Steps to Reproduce
------------------
Boot a UEFI install, look at the install logs

Expected Behavior
------------------
Noe errors reported in the instal logs

Actual Behavior
----------------
Above (see descrition) error messages appear in the logs

Reproducibility
---------------
100%

System Configuration
--------------------
Any UEFI installed node

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Sanity Testing

Workaround
----------
None needed, system installs fine.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/858223

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/858223
Committed: https://opendev.org/starlingx/metal/commit/b76322907948176e7ec991d5893cca5a037b6380
Submitter: "Zuul (22348)"
Branch: master

commit b76322907948176e7ec991d5893cca5a037b6380
Author: Robert Church <email address hidden>
Date: Fri Sep 16 13:41:14 2022 -0500

    Debian: Disable LAT BIOS grub updates for UEFI installs

    The LAT installer will attempt to write the legacy BIOS grub information
    after exiting from the %mkfs hook. Skip it, in case of a UEFI
    installation, as we don't have a BIOS boot partition to support legacy
    UEFI partition schemes.

    This eliminates grub install warnings/error that can be ignored as the
    UEFI installation is successful:

      /sbin/grub-install: error: will not proceed with blocklists.

    NOTE: The following message will now only be seen on BIOS booted labs as
          this is output from grub-install.

      Installation finished. No error reported.

    Test Plan:
    PASS - VBox AIO-SX UEFI/NVME clean install

    Signed-off-by: Robert Church <email address hidden>
    Closes-Bug: #1990016
    Change-Id: I5472ff13b3df32aab4c57f251ae87144096dc7ab