SNMP images are not pulled from registry.local

[Agustin Carranza]

Brief Description
------------------

SNMP helm chart does not pull the images from the registry.local:9001 for:

docker.io/starlingx/stx-fm-trap-subagent:stx.5.0-v1.0.1

docker.io/starlingx/stx-fm-subagent:stx.5.0-v1.0.0

Severity
------------------

Critical: System/Feature is not usable after the defect

A workaround was found but the large dependency on all pods being healthy, which seems to be problematic as well.

Steps to Reproduce
------------------

Follow documentation but with in an airgap deployment. Works in an environment with Internet access to the public registry.

Expected Behavior
------------------

SNMP application is deployed and working

Actual Behavior
------------------

Below images are not pulled from the registry.local:9001 for:

docker.io/starlingx/stx-fm-trap-subagent:stx.5.0-v1.0.1

docker.io/starlingx/stx-fm-subagent:stx.5.0-v1.0.0

But keep trying to pull from the internet.

Reproducibility
------------------

100% reproducible in airgap environment.

System Configuration
------------------

AIO-DX + worker and AIO + DX systems and AIO-SX

Load info (eg: 2022-03-10_20-00-07)

stx5.0

Last Pass
------------------

Did this test scenario pass previously? No

Timestamp/Logs
------------------

Alarms
------------------

Application apply failed

Test Activity
------------------

Feature Testing

Workaround
------------------

Add a helm-override for the image location and manually add the images into the registry.local:9001

create snmp-image.yaml file:

image:
  subagent_name: sub-agent
  repository_subagent: registry.local:9001/docker.io/starlingx/stx-fm-subagent
  tag_subagent: stx.5.0-v1.0.0
  pullPolicy_subagent: IfNotPresent
  trap_subagent_name: trap-subagent
  repository_trap_subagent: registry.local:9001/docker.io/starlingx/stx-fm-trap-subagent
  tag_trap_subagent: stx.5.0-v1.0.1
  pullPolicy_trap_subagent: IfNotPresent

then run:

system helm-override-update --reuse-values --values snmp-image.yaml snmp snmp kube-system

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/snmp-armada-app/+/856561

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Agustin Carranza <email address hidden>" on branch: master
Review: https://review.opendev.org/c/starlingx/snmp-armada-app/+/856561
Reason: It was already fixed in https://review.opendev.org/c/starlingx/snmp-armada-app/+/819698