stx-openstack: broken mariadb helmrelease on initial fluxcd app

[Thales Elero Cervi]

Brief Description
-----------------
During the initial stx-openstack fluxcd application tests it was noticed that the mariadb helmrelease is failing to render properly, breaking the apply procedure.

Severity
--------
Provide the severity of the defect.
Minor: Application apply always fails. stx-openstack fluxcd app stills in development phase though.

Steps to Reproduce
------------------
* Build the initial stx-openstack fluxcd app (https://review.opendev.org/c/starlingx/openstack-armada-app/+/840432)
* Upload stx-openstack with: system application-upload
* Apply stx-openstack with: system application-apply

Expected Behavior
------------------
stx-openstack (initial) fluxcd application is successfully applied.

Actual Behavior
----------------
stx-openstack (initial) fluxcd application fails to apply.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
master + https://review.opendev.org/c/starlingx/openstack-armada-app/+/840432

Last Pass
---------
N/A

Timestamp/Logs
--------------
[sysadmin@controller-0 ~(keystone_admin)]$ kubectl get helmrelease -n openstack
NAME READY STATUS AGE
garbd True Release reconciliation succeeded 48m
ingress True Release reconciliation succeeded 48m
mariadb False Helm install failed: error while running post render on files: map[string]interface {}{"apiVersion":"v1", "data":map[interface {}]interface {}{3306:"openstack/mariadb-server:3306"}, "kind":"ConfigMap", "metadata":map[string]interface {}{"labels":map[string]interface {}{"helm.toolkit.fluxcd.io/name":"mariadb", "helm.toolkit.fluxcd.io/namespace":"openstack"}, "name":"mariadb-services-tcp"}}: json: unsupported type: map[interface {}]interface {} 48m
memcached False dependency 'openstack/mariadb' is not ready 48m
nginx-ports-control True Release reconciliation succeeded 48m
openstack-psp-rolebinding True Release reconciliation succeeded 8m
rabbitmq False dependency 'openstack/memcached' is not ready 48m

---> "data":map[interface {}]interface {}{3306:"openstack/mariadb-server:3306"},
json: unsupported type: map[interface {}]interface {}

Test Activity
-------------
Developer Testing

Workaround
----------
None

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/openstack-armada-app/+/852471
Committed: https://opendev.org/starlingx/openstack-armada-app/commit/3d8844ef7e0f76b7c8fe66231e5ce639acdbfbe2
Submitter: "Zuul (22348)"
Branch: master

commit 3d8844ef7e0f76b7c8fe66231e5ce639acdbfbe2
Author: Thales Elero Cervi <email address hidden>
Date: Mon Aug 8 19:36:14 2022 -0300

    Making mariadb (osh-i) char helm v3 compatible

    The patch added by this change will make openstack-helm-infra
    mariadb chart syntax compatible with FluxCD (helmv3).
    Tests done with osh-i charts as they were used on our armada app
    failed with helm release render errors.

    Test Plan:
    PASS - build-helm-charts.sh builds a basic FluxCD and a complete Armada
           app tarball
    PASS - application upload and overrides generated
    PASS - application apply/remove/delete

    Closes-Bug: 1987705

    Signed-off-by: Thales Elero Cervi <email address hidden>
    Change-Id: Ie26ebd10833e797652e24d4736d15d8c89cba1e4