Bootloader generation script is missing in CentOS build

[Tee Ngo]

Brief Description
-----------------
Subcloud deployment in CentOS failed due to missing gen-bootloader-iso-centos.sh

Severity
--------
Critical

Steps to Reproduce
------------------
Bring up a DC system in CentOS

Expected Behavior
------------------
Subcloud deployment is successful

Actual Behavior
----------------
Subcloud deployment failed with the following error

2022-08-12 10:44:50.518 139265 INFO dccommon.subcloud_install [-] Running update_iso_cmd: /usr/local/bin/gen-bootloader-iso-centos.sh --input /opt/dc-vault/loads/22.12/bootimage.iso --www-root /opt/platform/iso/22.12 --id subcloud2 --boot-hostname subcloud2 --timeout 5 --param rootfs_device=/dev/disk/by-path/pci-0000:b4:00.0-nvme-1 --boot-ip [2620:10a:a001:d41::192] --param boot_device=/dev/disk/by-path/pci-0000:b4:00.0-nvme-1 --default-boot 2 --boot-netmask 64 --boot-interface enp179s0f0 --addon /var/opt/dc/ansible/subcloud2/ks-addon.cfg --base-url http://[2620:10a:a001:d41::1103]:8080/iso/22.12
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager [-] [Errno 2] No such file or directory: OSError: [Errno 2] No such file or directory
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager Traceback (most recent call last):
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib/python2.7/site-packages/dcmanager/manager/subcloud_manager.py", line 714, in run_deploy
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager payload['install_values'])
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib/python2.7/site-packages/dccommon/subcloud_install.py", line 550, in prep
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager self.update_iso(override_path, iso_values)
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib/python2.7/site-packages/dccommon/subcloud_install.py", line 398, in update_iso
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager update_iso_cmd, stdout=fnull, stderr=fnull)
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib64/python2.7/subprocess.py", line 537, in check_call
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager retcode = call(*popenargs, **kwargs)
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib64/python2.7/subprocess.py", line 524, in call
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager return Popen(*popenargs, **kwargs).wait()
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 58, in __init__
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib64/python2.7/subprocess.py", line 711, in __init__
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager errread, errwrite)
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager File "/usr/lib64/python2.7/subprocess.py", line 1327, in _execute_child
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager raise child_exception
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager OSError: [Errno 2] No such file or directory
2022-08-12 10:44:50.561 139265 ERROR dcmanager.manager.subcloud_manager
2022-08-12 10:44:50.597 139265 ERROR dcmanager.manager.subcloud_manager [-] [Errno 2] No such file or directory: OSError: [Errno 2] No such file or directory

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed Cloud

Branch/Pull Time/Commit
-----------------------
Aug. 11th, 2022 master branch

Last Pass
---------
DC system bringup was successful in CentOS prior to this commit
https://review.opendev.org/c/starlingx/utilities/+/851688

Timestamp/Logs
--------------
See above

Test Activity
-------------
Sanity

Workaround
----------
Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/utilities/+/853023

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/853023
Committed: https://opendev.org/starlingx/utilities/commit/77f1279b0c049cb7e6cfab2457fb44cc3bbf8886
Submitter: "Zuul (22348)"
Branch: master

commit 77f1279b0c049cb7e6cfab2457fb44cc3bbf8886
Author: Tee Ngo <email address hidden>
Date: Fri Aug 12 16:53:54 2022 -0400

    Package the right gen-bootloader-iso.sh for CentOS

    The gen-bootloader-iso.sh script for CentOS was renamed in commit
    https://review.opendev.org/c/starlingx/utilities/+/851688. However,
    the CentOS build spec was not updated to reflect the name change
    resulting in subcloud deployment failure. This commit fixes it.

    Test Plan:
      - Verify successful subcloud deployment in CentOS

    Partial-Bug: 1986054
    Change-Id: I741a14652ab0541a02a4ae07a3f68a09dd1e2b8c
    Signed-off-by: Tee Ngo <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/853024

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/853024
Committed: https://opendev.org/starlingx/distcloud/commit/394d1ceff9a022d49ee0727830d04948e4a5ae46
Submitter: "Zuul (22348)"
Branch: master

commit 394d1ceff9a022d49ee0727830d04948e4a5ae46
Author: Tee Ngo <email address hidden>
Date: Fri Aug 12 17:22:06 2022 -0400

    Invoke the correct gen-bootloader-iso.sh script based on distro

    The gen-bootloader-iso.sh script for CentOS was renamed and invoked in
    previous commits to utilities [1] and distributedcloud [2] repos.
    However, the renamed script was not packaged and installed
    resulting in subcloud deployment failure in CentOS based StarlingX.

    The issue is resolved by
    https://review.opendev.org/c/starlingx/utilities/+/853023 and this commit.

    [1] https://review.opendev.org/c/starlingx/utilities/+/851688
    [2] https://review.opendev.org/c/starlingx/distcloud/+/851679

    Test Plan:
       - Verify successful subcloud deployment in CentOS
       - Verify proper cleanup of shared and subcloud specific boot files
         post remote install

    Closes-Bug: 1986054
    Change-Id: If5261f2a96447c4f45ac7c38a785eea10c1802e5
    Signed-off-by: Tee Ngo <email address hidden>