host-device-show doesn't show firmware info

[Mohammad Issa]

Brief Description

[Debian] host-device-show doesn't show firmware info

=================================================================

Severity

Major

=================================================================

Steps to Reproduce

system host-device-show controller-0 0000:b2:00.0

=================================================================

Expected Behavior

firmware info shows output similar as below

| created_at | 2022-06-10T19:49:32.797560+00:00 |
| updated_at | 2022-06-14T12:26:52.363512+00:00 |
| root_key | |
| revoked_key_ids | |
| boot_page | user |
| bitstream_id | 0x2383a62a010504 |
| bmc_build_version | D.2.0.7 |
| bmc_fw_version | D.2.238.24 |
| retimer_a_version | 101c.105c |
| retimer_b_version | 0000.0000 |

=================================================================

Actual Behavior

firmawre info all showed as None

| created_at | 2022-06-10T02:36:55.447125+00:00 |
| updated_at | 2022-06-13T14:49:49.447267+00:00 |
| root_key | None |
| revoked_key_ids | None |
| boot_page | None |
| bitstream_id | None |
| bmc_build_version | None |
| bmc_fw_version | None |
| retimer_a_version | None |
| retimer_b_version | None |

=================================================================

Reproducibility

reproducible

=================================================================

System Configuration

wp_15

=================================================================

Branch/Pull Time/Commit

stx-debian-pipeline 2022-06-07_19-00-50

=================================================================

Last Pass

Centos build

=================================================================

Timestamp/Logs
[sysadmin@controller-0 ~(keystone_admin)]$ system host-device-show controller-0 0000:b2:00.0

+-----------------------+----------------------------------+
| Property | Value |
+-----------------------+----------------------------------+
| name | pci_0000_b2_00_0 |
| address | 0000:b2:00.0 |
| class id | 120000 |
| vendor id | 8086 |
| device id | 0b30 |
| class name | Processing accelerators |
| vendor name | Intel Corporation |
| device name | Device 0b30 |
| numa_node | 1 |
| enabled | True |
| sriov_totalvfs | 1 |
| sriov_numvfs | 0 |
| sriov_vfs_pci_address | |
| sriov_vf_pdevice_id | None |
| extra_info | None |
| created_at | 2022-06-10T02:36:55.447125+00:00 |
| updated_at | 2022-06-13T14:49:49.447267+00:00 |
| root_key | None |
| revoked_key_ids | None |
| boot_page | None |
| bitstream_id | None |
| bmc_build_version | None |
| bmc_fw_version | None |
| retimer_a_version | None |
| retimer_b_version | None |
| driver | intel-fpga-pci |
| sriov_vf_driver | None |
+-----------------------+----------------------------------+

=================================================================

Test Activity

Regression Testing

=================================================================

Workaround

Describe workaround if available

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/config/+/850022

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/config/+/850022
Committed: https://opendev.org/starlingx/config/commit/86aa93255e96ec370666a24e3477e827a11873cf
Submitter: "Zuul (22348)"
Branch: master

commit 86aa93255e96ec370666a24e3477e827a11873cf
Author: Mohammad Issa <email address hidden>
Date: Fri Jul 15 15:21:26 2022 +0000

    host-device-show doesn't show firmware info

    When running "system host-device-show controller-0 0000:b2:00.0",
    all firmware info are shown as "None".

    Turns out some services like "sysinv-fpga-agent" and
    "sysinv-conf-watcher" are not initialized properly during initial boot.

    Test Plan:

    PASS: modify the rules script that is used to start systemd unit files,
          to become compatible with the Debian command rules. for example,
          specifying the name of the service with the "--name" option:
          "--name=sysinv-fpga-agent". Then execute:
          "ls /usr/lib/systemd/system/sysinv* -l" after initial boot
          --> Command Response:
              -rw-r--r-- 3 root root 81 Jan 1 1970
              /usr/lib/systemd/system/sysinv-conf-watcher.path

              -rw-r--r-- 3 root root 219 Jan 1 1970
              /usr/lib/systemd/system/sysinv-conf-watcher.service

              -rw-r--r-- 3 root root 389 Jan 1 1970
              /usr/lib/systemd/system/sysinv-fpga-agent.service

    Closes-Bug: 1981824

    Signed-off-by: Mohammad Issa <email address hidden>
    Change-Id: I1491e9607688738fedec188c872a815b074e8dfc

[Ghada Khalil (gkhalil)]

Re-opening as verification failed

[Ghada Khalil (gkhalil)]

Review posted: https://review.opendev.org/c/starlingx/config/+/856361

[Ghada Khalil (gkhalil)]

Follow-up fix merged on Sept 12. Review: https://review.opendev.org/c/starlingx/config/+/856361