ptp-notification pod gets not running after application-apply

[Douglas Henrique Koerich]

Brief Description
-----------------
After applying ptp-notification application, the pod fails to run due to incorrect configuration (lack of legacy PTP socket).

Severity
--------
Critical: ptp-notification feature isn't usable

Steps to Reproduce
------------------
- Configure some ptp4l instance other than legacy (from deprecated configuration)
- Enable and apply ptp-notification application
- Wait for pod gets running, it never reaches such state

Expected Behavior
------------------
After downloading the corresponding containers, the pod is expected to be in "Running" state

Actual Behavior
----------------
Pod is stuck in "ContainerCreating" state

Reproducibility
---------------
Reproducible

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
master

Last Pass
---------
Unknown

Timestamp/Logs
--------------
Events:
  Type Reason Age From Message
  ---- ------ ---- ---- -------
  Normal Scheduled 5m20s default-scheduler Successfully assigned notification/ptp-ptp-notification-gpg7l to controller-0
  Warning FailedMount 3m17s kubelet Unable to attach or mount volumes: unmounted volumes=[varrun], unattached volumes=[varrun pmc conf kube-api-access-j4w8l scripts ptpdir]: timed out waiting for the condition
  Warning FailedMount 70s (x10 over 5m20s) kubelet MountVolume.SetUp failed for volume "varrun" : hostPath type check failed: /var/run/ptp4l-legacy is not a socket file
  Warning FailedMount 60s kubelet Unable to attach or mount volumes: unmounted volumes=[varrun], unattached volumes=[kube-api-access-j4w8l scripts ptpdir varrun pmc conf]: timed out waiting for the condition

Test Activity
-------------
Developer Testing

Workaround
----------
Configure a fake legacy PTP instance and re-apply PTP configuration in order to get /var/run/ptp4l-legacy socket created

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/850057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/ptp-notification-armada-app/+/850057
Committed: https://opendev.org/starlingx/ptp-notification-armada-app/commit/f7475d56083b1fb77b5024668a403967e82e6df0
Submitter: "Zuul (22348)"
Branch: master

commit f7475d56083b1fb77b5024668a403967e82e6df0
Author: Douglas Henrique Koerich <email address hidden>
Date: Fri Jul 15 14:32:09 2022 -0300

    Fix bad ptp4l socket spec for ptptracking

    This change fixes two issues found in the helm chart specification for
    ptp-notification application:
    1) Correct name of socket in the host when legacy PTP configuration is
       found;
    2) Avoid failure in the pod creation when no legacy PTP configuration is
       found, since the original hostPath type "Socket" is required to
       exist, which is not the case in that (valid) scenario. In this case,
       the "type" field is reset which causes the path check to be dismissed

    Test Plan:
    PASS: Pod (containers) running with changed (fixed) ptp-notification tgz

    Closes-Bug: 1981821
    Signed-off-by: Douglas Henrique Koerich <email address hidden>
    Change-Id: I0efc1bdec525366ef09a87f1d0fc311cc5216656