Debian: pxeboot install of controller-1 fails on efi.img fetch

[Eric MacDonald]

Brief Description
-----------------
Pxeboot install of controller-1 fails on efi.img fetch.

The feed directory is supposed to resemble the layout of the mounted ISO.
The kickstart is mistakenly putting it into the feed's pxeboot dir.

Severity
--------
Critical: System node install fails.

Steps to Reproduce
------------------
Install a system node

Expected Behavior
------------------
System node is installed

Actual Behavior
----------------
Install failure

Reproducibility
---------------
100%

System Configuration
--------------------
Two node system, Multi-node system

Branch/Pull Time/Commit
-----------------------
July 11, 2022

Last Pass
---------
not yet

Timestamp/Logs
--------------
2022-07-12 22:38:50.289 kickstart post_nochroot info: Fetch efi.img from http://pxecontroller:8080/feed/rel-22.06/ to /sysroot/ostree/1/var/www/pages/feed/rel-22.06
2022-07-12 22:38:50.289 kickstart post_nochroot info: ... fetching efi.img to /sysroot/ostree/1/var/www/pages/feed/rel-22.06

Installation failed.

2022-07-12 23:00:22.041 kickstart post_nochroot warn: Installation Failed: ERROR: Failed to get http://pxecontroller:8080/feed/rel-22.06//efi.img

Test Activity
-------------
Developer Testing

Workaround
----------
sudo mv /var/www/pages/feed/rel-22.06/pxeboot/efi.img /var/www/pages/feed/rel-22.06

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/metal/+/849591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/metal/+/849591
Committed: https://opendev.org/starlingx/metal/commit/d36db00bdb0272c41d2184cb99f595aa34eb6896
Submitter: "Zuul (22348)"
Branch: master

commit d36db00bdb0272c41d2184cb99f595aa34eb6896
Author: Eric MacDonald <email address hidden>
Date: Wed Jul 13 00:53:18 2022 +0000

    Debian: Position efi.img in the feed to replicate mounted iso feed

    The efi.img file appears in the root directory of a mounted ISO.
    The Debian kickstart copied it to the pxeboot server's feed/pxeboot
    directory rather than the feed's root.

    This update places the efi.img in the root directory of the feed as
    it would appear in a mounted ISO.

    Test Plan:

    PASS: Verify Debian Build and USB Install
    PASS: Verify system node install from a USB installed
          pxeboot server.

    Closes-Bug: 1981503
    Signed-off-by: Eric MacDonald <email address hidden>
    Change-Id: I14ed96a65f9921f15bdf269ecba643595121aa92