stx-openstack: Can't update OSH-I without changing platform-armada-app and stx-sdo-helm

[Thales Elero Cervi]

Brief Description
-----------------
When trying to update openstack-helm-infra for stx-openstack [1] the helm-toolkit chart version was needed to be upgraded from 0.2.19 to 0.2.42. Building the openstack-armada-app packages worked fine but the full build failed for both: platform-armada-app and stx-sdo-helm that strongly depend on the helm-toolkit that openstack-helm-infra brings.

So we are currently blocked on upgrading openstack-helm-infra to recent commits (with possible bug fixes) until this dependency between repos is broken.

Severity
--------
Minor

Steps to Reproduce
------------------
* Update openstack-helm-infra to a recent commit (example in [1])
* Trigger build-pkgs script

Expected Behavior
------------------
Packages described in different repos should not strongly depend on charts brought by openstack-helm-infra on this repo.

Actual Behavior
----------------
Packages described in different repos strongly depend on helm-toolkit chart version that is brought by openstack-helm-infra on this repo and therefore the build fails for both: platform-armada-app and stx-sdo-helm.

Reproducibility
---------------
Reproducible

System Configuration
--------------------
N/A

Branch/Pull Time/Commit
-----------------------
stx/master

Last Pass
---------
Day 0 behavior.

Timestamp/Logs
--------------
08:52:17 Failed to build packages: stx-sdo-helm-1.0-6.tis.src.rpm stx-platform-helm-1.0-52.tis.src.rpm

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.mZx6kF
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd stx-platform-helm-1.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
+ umask 022
+ cd /builddir/build/BUILD
+ cd stx-platform-helm-1.0
+ cp /usr/lib/helm/helm-toolkit-0.2.19.tgz helm-charts/
cp: cannot stat '/usr/lib/helm/helm-toolkit-0.2.19.tgz': No such file or directory
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.mZx6kF (%build)
    Bad exit status from /var/tmp/rpm-tmp.mZx6kF (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 547, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

NOTE: My suggestion would be to create a new package (e.g. helm-toolkit) to be fixed on the current helm-toolkit version needed by both platform-app and sdo, or by any other application that require it. We use the armada-helm-toolkit when want to update openstack-helm-infra charts and other apps would still be pointing to the spec with the old helm-toolkit version until they have time to catch-up. Something on this direction...

[1] https://review.opendev.org/c/starlingx/openstack-armada-app/+/848336

[Thiago Paiva Brito (outbrito)]

I strongly recommend exporting the helm-toolkit that those apps currently uses for a new package as we did for the armada version of helm-toolkit on [1] so we break this dependency once and for all.

[1]https://opendev.org/starlingx/integ/commit/8ceb938222ddaf3b8c7e772da94054d505e77eb0

[Thales Elero Cervi (tcervi)]

This was fixed by: https://review.opendev.org/c/starlingx/SDO-rv-service/+/886739